Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issues raised by recent reviews #89

Merged
merged 23 commits into from Mar 28, 2023
Merged

Address issues raised by recent reviews #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
de6fe7f
Add guidance for generating bidirectional text from substrings or for
aphillips Jan 27, 2023
7b24ade
Address #83
aphillips Jan 27, 2023
85fc0dc
Address #69
aphillips Jan 27, 2023
b73b570
Corrections and minor cleanup for the bidi example.
aphillips Jan 28, 2023
d0c0799
Addresses #14
aphillips Jan 29, 2023
57e9fb5
Address @r12a's comment about language tags.
aphillips Jan 30, 2023
3910539
Address @r12a's comment about "isolating bidi controls"
aphillips Jan 30, 2023
7825d50
Fixed bidi example by using markup.
aphillips Jan 31, 2023
bb58dfa
Address teleconference comments.
aphillips Feb 2, 2023
54d1b8b
Improve color contrast in example 3
aphillips Feb 2, 2023
1a2991b
Further simplified bidi example.
aphillips Feb 2, 2023
cc2f39e
Additional work on sorting section.
aphillips Feb 2, 2023
e16100d
Fix description of BCP47 and of matching
aphillips Feb 7, 2023
6da1a39
Minor tweak to ascending code unit sort.
aphillips Feb 7, 2023
2244c70
Added text to description of the matching BP
aphillips Feb 7, 2023
676694b
Address comments on #bidi_gen section from telecon of 2023-02-09
aphillips Feb 9, 2023
a54cf2f
Move explanation under mustard.
aphillips Feb 9, 2023
48fa92a
Ensure all parts of 639 are dealt with, minor edits
aphillips Feb 9, 2023
a7a3897
Further rephrasing based on @r12a's comments in telecon
aphillips Feb 10, 2023
f64e6d2
Further edits to make reqs refer to string values.
aphillips Feb 10, 2023
1caf816
Address telecon 2023-02-16 comments
aphillips Feb 16, 2023
07cbc60
Address @xfq's comment about vertical-align
aphillips Feb 28, 2023
6ce0aea
Update bidi recommendation from telecon of 2023-03-09 [I18N-ACTION-1253]
aphillips Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view