Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normative(PaymentComplete): replace '' with 'unknown' (closes #308) #312

Merged
merged 1 commit into from
Dec 1, 2016

Conversation

marcoscaceres
Copy link
Member

No description provided.

@marcoscaceres
Copy link
Member Author

Hmm... maybe this should be "abort". @rsolomakhin, do you have any thoughts on this?

@rsolomakhin
Copy link
Collaborator

I would prefer not to change this part of the spec. If we do change it, complete('unknown') matches the meaning of complete(''). Let's not use 'abort', because it can be confused with abort() method, whose meaning and behavior are different.

@adrianba
Copy link
Contributor

It's definitely not 'abort' - that would be a very different meaning. You call this with '' or 'unknown' when the transaction is in progress not when you are aborting.

@marcoscaceres
Copy link
Member Author

@rsolomakhin, yeah, ignore my "abort" suggestion.

However, I'd really like to see "" changed to "unknown" on the Moz side for the reasons I mentioned in #308.

@zkoch
Copy link
Contributor

zkoch commented Nov 30, 2016

This LGTM

@rvm4 rvm4 merged commit 380870f into gh-pages Dec 1, 2016
@marcoscaceres marcoscaceres deleted the bug_308_PaymentComplete_enum branch February 17, 2017 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants