Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial changes #465

Merged
merged 3 commits into from Mar 21, 2017
Merged

Editorial changes #465

merged 3 commits into from Mar 21, 2017

Conversation

ianbjacobs
Copy link
Collaborator

@ianbjacobs ianbjacobs commented Mar 20, 2017

Some editorial changes:

  • Payment methods describe data; they are not participants in a transaction.
    Therefore, recast the description of parties as payers/payees/providers
    of payment methods. (Both in Intro and Goals)

  • The word "buyer" was used in the intro and not used elsewhere in the
    spec. Therefore, I use payer/payee which are used further down.

  • The first examples the reader should encounter in the PaymentRequest
    interface description should be those most likely found in practice.
    The "Buy" button should come first. The other examples of in-app
    and POS are much further out and so I have listed them after.

  • Updated example 2 as follows:

    • We have network id values; we should use those instead of fictitious
      ones.

    • bobpay.com does not confirm (I believe) to the PMI spec. So I have
      used an example URL instead.


Preview | Diff

 * Payment methods describe data; they are not participants in a transaction.
   Therefore, recast the description of parties as payers/payees/providers
   of payment methods. (Both in Intro and Goals)

 * The word "buyer" was used in the intro and not used elsewhere in the
   spec. Therefore, I use payer/payee which are used further down.

 * The first examples the reader should encounter in the PaymentRequest
   interface description should be those most likely found in practice.
   The "Buy" button should come first. The other examples of in-app
   and POS are much further out and so I have listed them after.

 * Updated example 2 as follows:

   - We have network id values; we should use those instead of fictitious
     ones.

   - bobpay.com does not confirm (I believe) to the PMI spec. So I have
     used an example URL instead.
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run tidy over the doc

@ianbjacobs
Copy link
Collaborator Author

@marcoscaceres,

I have just installed HTML Tidy version 5.5.10. What options should I run it with? I used '-i' but the result seems very different from the input file. That is: a lot more is changed by tidy than I changed via my edit. Please advise.

Ian

@marcoscaceres
Copy link
Member

@ianbjacobs, run:

tidy -config tidyconfig.txt -o index.html index.html

char-encoding: utf8
indent: yes
wrap: 80
tidy-mark: no
index.html Outdated
a transaction:</p>

<ul>
<li>the payee, such as a merchant with an online store,</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer these ended in full stop.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*each of these

index.html Outdated
</p>
<ul>
<li>the payee, such as a merchant with an online store,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still like this to be:

  • The payee: bla bla bla.
  • The payer: bla bla bla.
  • The provider: bla bla bla.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants