Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for auth token in GITHUB_TOKEN (was GH_TOKEN) #1308

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

tidoust
Copy link
Member

@tidoust tidoust commented Apr 15, 2024

Via #1307.

The gh command that we now use in some of our jobs look for a GITHUB_TOKEN environment variable to find the authentication token, while our code rather used GH_TOKEN.

The job that checks a suggested spec uses both our code and the gh command. To avoid having to set the token to two different environment variables, this updates rather aligns everything to GITHUB_TOKEN.

The `gh` command that we now use in some of our jobs look for a `GITHUB_TOKEN`
environment variable to find the authentication token, while our code rather
used `GH_TOKEN`.

The job that checks a suggested spec uses both our code and the `gh` command.
To avoid having to set the token to two different environment variables, this
updates rather aligns everything to `GITHUB_TOKEN`.
@tidoust tidoust merged commit 2911507 into main Apr 15, 2024
1 check passed
@tidoust tidoust deleted the github-token branch April 15, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants