Add new composition level: "fork" #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new composition level is meant for specs that are created as temporary forks of base specifications. First (and only so far) spec in that category is the "WebAssembly JavaScript Interface: Exception Handling" specification, as described in #508. This will require a major version bump as this changes the semantics of the `seriesComposition` property.
Sharon077
approved these changes
Feb 24, 2022
Take 2 on handling temporary forks of base specifications, as described in #508. In the final list, forks will be identified both because they will have a `seriesComposition` property set to `"fork"`, and because they will have a `forkOf` property that contains the shortname of the spec that they are a fork of. The shortname of forks will always be something like `[base shortname]-fork-[shortname]` (no longer such a short name, isn't it?) Specifications that have forks will now also have a `forks` property that lists the shortnames of the forks. Forks no longer take part in `seriesPrevious`, `seriesNext` links.
|
I updated the pull request to link fork and base specs through |
dontcallmedom
approved these changes
Feb 25, 2022
Integrate feedback and make sure that: 1. linter actually rejects entries that have both a `forkOf` and a `seriesComposition` property. 2. tests reject inputs with inconsistent `forkOf` and `seriesComposition` properties. Also fixes the `fork` reduction that is no longer valid (fork specs must specify their base spec so cannot be specified with just a URL that ends with ` fork`).
A key constraint was missing from the filtering logic...
…related properties
Sharon077
approved these changes
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new composition level is meant for specs that are created as temporary forks of base specifications. First (and only so far) spec in that category is the "WebAssembly JavaScript Interface: Exception Handling" specification, as described in #508.
This will require a major version bump as this changes the semantics of the
seriesCompositionproperty.(I'll work on an update to Reffy to handle fork specs)