Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various issues with the login functionality #80

Open
jnurthen opened this issue Feb 9, 2022 · 1 comment
Open

various issues with the login functionality #80

jnurthen opened this issue Feb 9, 2022 · 1 comment
Labels
enhancement For enhancement on existing features

Comments

@jnurthen
Copy link
Member

jnurthen commented Feb 9, 2022

  • It is implemented as a link not a button. It looks and performs like a button (I understand it is implemented as a link but it doesn't really perform navigation) so IMO should be a button (note - there will probably be contrary opinions on this)
  • The login button / status message is hidden when on viewports less that 992px width. This makes it impossible to tell if you are logged in without expanding the hamburger button. Whether the user is logged in or not is important enough it should not be hidden in any viewport.
@swickr
Copy link
Contributor

swickr commented Apr 1, 2022

+1 to displaying the logged-in/not-logged-in state at the top of the window regardless of the window width. One should not have to open the hamburger menu to be reminded.

@swickr swickr added the enhancement For enhancement on existing features label Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For enhancement on existing features
Projects
None yet
Development

No branches or pull requests

2 participants