Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ac review #29

Merged
merged 5 commits into from May 18, 2018
Merged

Ac review #29

merged 5 commits into from May 18, 2018

Conversation

plehegar
Copy link
Member

@plehegar plehegar commented May 3, 2018

This pull request addresses the ongoing feedback from the AC Review.

@@ -447,7 +447,7 @@ <h2>Coordination</h2>
Invitation for review must be issued during each major standards-track
document transition, including <a href="https://www.w3.org/2018/Process-20180201/#RecsWD"

title="First Public Working Draft">FPWD</a> and at least 3 months
title="First Public Working Draft">FPWD</a> and should be issued at least 3 months
before <a href="https://www.w3.org/2018/Process-20180201/#RecsCR" title="Candidate Recommendation">CR</a>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semi-colon or comma missing before should be issued at least 3 months

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the and should be issued at least I think?

@@ -589,7 +589,7 @@ <h2> Decision Policy </h2>
face-to-face meeting or teleconference will be considered provisional.
A call for consensus (CfC) will be issued for all resolutions (for
example, via email and/or web-based survey), with a response period
from one week to 10 working days, depending on the chair's evaluation
of 10 working days, depending on the chair's evaluation
of the group consensus on the issue. If no objections are raised on
the mailing list by the end of the response period, the resolution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the following be removed now?

, depending on the chair's evaluation of the group consensus on the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please remove the , depending on the chair's evaluation of the group consensus on the issue since it is no longer applicable.

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing the pull request @plehegar - I agree with @palemieux that a couple of detail changes are needed still.

@@ -447,7 +447,7 @@ <h2>Coordination</h2>
Invitation for review must be issued during each major standards-track
document transition, including <a href="https://www.w3.org/2018/Process-20180201/#RecsWD"

title="First Public Working Draft">FPWD</a> and at least 3 months
title="First Public Working Draft">FPWD</a> and should be issued at least 3 months
before <a href="https://www.w3.org/2018/Process-20180201/#RecsCR" title="Candidate Recommendation">CR</a>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the and should be issued at least I think?

@@ -589,7 +589,7 @@ <h2> Decision Policy </h2>
face-to-face meeting or teleconference will be considered provisional.
A call for consensus (CfC) will be issued for all resolutions (for
example, via email and/or web-based survey), with a response period
from one week to 10 working days, depending on the chair's evaluation
of 10 working days, depending on the chair's evaluation
of the group consensus on the issue. If no objections are raised on
the mailing list by the end of the response period, the resolution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please remove the , depending on the chair's evaluation of the group consensus on the issue since it is no longer applicable.

@plehegar
Copy link
Member Author

plehegar commented May 8, 2018

changes requested by @palemieux done. Thank you for the thorough review!

@nigelmegitt
Copy link
Contributor

Thanks, looking good so far!

@plehegar plehegar merged commit 9a39200 into gh-pages May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants