Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to format type size equivalents in a table format #141

Closed
huijing opened this issue Mar 28, 2017 · 3 comments
Closed

Suggest to format type size equivalents in a table format #141

huijing opened this issue Mar 28, 2017 · 3 comments

Comments

@huijing
Copy link
Contributor

huijing commented Mar 28, 2017

For section 2.3.5 Considerations when Designing the Type Area | 版心设计的注意事项 | 版心設計的注意事項, the note that describes the Western sizing equivalent of Chinese type size systems may be better presented in a table format.
Is it ok for me to make the format change and submit a pull request for this?

@ryukeikun
Copy link
Contributor

It is OK to change the format. However, the contents need to be re-written and I will make a new issue for it.

@huijing
Copy link
Contributor Author

huijing commented Apr 3, 2017

I have updated the format into a table, however, no changes have been made to the content as those should be addressed in #142
I also realised that my first pull request addressing #139 hadn't been merged yet, and commit b532a4d contains the changes for both issues.

@xfq
Copy link
Member

xfq commented Jul 27, 2018

I think this issue can be closed, because we have #142.

@xfq xfq closed this as completed Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants