Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof read and edit English translation from 1–2.3 #139

Merged
merged 2 commits into from
Apr 3, 2017
Merged

Proof read and edit English translation from 1–2.3 #139

merged 2 commits into from
Apr 3, 2017

Conversation

huijing
Copy link
Contributor

@huijing huijing commented Mar 28, 2017

Fixed some typos and punctuation as well as re-worded some sentences to flow better

index.html Outdated
@@ -325,7 +325,7 @@ <h6 data-lang="zh-hant">發表對本文檔的建議</h6>
<p data-lang="en">Chinese characters include Traditional Chinese and Simplified Chinese alternatives. The former is commonly used in Taiwan, Hong Kong and Macao while the latter is commonly used in Mainland China, Singapore and Malaysia.</p>
<p data-lang="zh-hans">依照各地的通行标准,中文所使用的汉字主要分为繁体字与简体字。前者又称正体字、传统汉字等,主要通行于台湾、香港、澳门等地;后者又作简化字,主要通行于中国大陆、星马地区。本文依笔画多寡与部件结构为区别,统称为繁体字与简体字。</p>
<p data-lang="zh-hant">依照各地的通行標準,中文所使用的漢字主要分為繁體字與簡體字。前者又作正體字、傳統漢字等,主要通行於台灣、香港、澳門等地;後者又作簡化字,主要通行於中國大陸、星馬地區。本文依筆畫多寡與部件結構為區別,統稱為繁體字與簡體字。</p>
<p data-lang="en">Different glyphs are used in different regions. One Unicode code point of a Chinese character may have more than one valid glyph, depending on operating systems and typefaces. The focus of this document is Chinese composition and will not discuss more about glyph variations.</p>
<p data-lang="en">Different glyphs are used in different regions. One Unicode code point of a Chinese character may have more than one valid glyph, depending on operating system and typeface used. The focus of this document is Chinese composition and will not discuss cover glyph variations in detail.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The focus of this document is Chinese composition and will not discuss cover glyph variations in detail

maybe say

The focus of this document is Chinese composition and it will not cover glyph variations in detail

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed out the word "discuss" when deleting. Fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you add the word 'it' too ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, i see you didn't. No big deal, just a suggestion. Ignore if you want.

index.html Outdated
<p data-lang="zh-hans">图片与表格之说明文字字数较少时,为取得平衡,而加大字距。</p>
<p data-lang="zh-hant">圖片與表格之說明文字字數较少時,為取得平衡,而加大字距。</p>
</li>
<li>
<p data-lang="en">In some cases, increased inter-character spacing is used for poetry where one line has only a few characters, so as to maintain the balance of the layout.</p>
<p data-lang="en">In some cases, increased inter-character spacing is used for poetry, where one line has only a few characters, so as to maintain the balance of the layout.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comma changes the meaning. Previously it implied that spacing is used only for lines in a poem that have a small number of characters. Now it implies that, because lines in poems have a small number of characters in general spacing is applied liberally to lines in poems. Which is correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first interpretation is correct. Changed it to read "used for poetry with lines of only a few characters"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about: used in poetry for lines which have only a few characters

@@ -449,7 +449,7 @@ <h6 data-lang="zh-hant">發表對本文檔的建議</h6>
<p data-lang="zh-hant">減少字距,使得文字外框一部分重疊,稱作紧排。這種處理方式,主要應用於:</p>
<ol>
<li>
<p data-lang="en">For characters in headings in magazines or advertisements, reduced inter-character spacing can be used to keep the characters on one line, or it can also be used to achieve a special effect for presentation.</p>
<p data-lang="en">For characters in headings of magazines or advertisements, reduced inter-character spacing can be used to keep the characters on one line, or it can also be used to achieve a special effect for presentation.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit: i think 'in' is correct if we are referring to headings of articles. 'Of' in 'in headings of magazines' sounds like the translation should have been 'of magazine titles', ie. the name of the magazine. Just a suggestion. Ignore if you wish.

index.html Outdated
@@ -631,16 +631,16 @@ <h6 data-lang="zh-hant">發表對本文檔的建議</h6>
<p data-lang="en">Books usually use one basic template for page format, whereas magazines often use several templates.</p>
<p data-lang="zh-hans">书籍多数仅使用一种基础版式体裁,杂志则会使用上数种。</p>
<p data-lang="zh-hant">書籍多數僅使用一種基礎排版體裁,雜誌則會使用上數種。</p>
<p data-lang="en">Although in books, there tends to be one template for the page format, some further design effort based around the basic page format will be needed for pages such as the table of contents and indexes. Furthermore, there are many examples of indexes with a different page format than the basic page format, and vertically set books often have indexes in horizontal writing mode, and sometimes multiple columns. However, while doing actual design for the page, the size of the type area should not exceed the basic page template.<span class="issue"> (some doubts about the translation of 版面 here)</span>.</p>
<p data-lang="en">Although books tend to use one template for its page format, some further design effort based will be needed to extend that template for pages such as the table of contents and indexes. Furthermore, there are many examples of indexes with a different page format than the basic page format, and vertically set books often have indexes in horizontal writing mode, and sometimes multiple columns. However, while doing actual design for the page, the size of the type area should not exceed the basic page template.<span class="issue"> (some doubts about the translation of 版面 here)</span>.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this one went a bit haywire.
'for its page format' -> 'for their page format'
'some further design effort based will be' -> 'some further design effort will be'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another missed deletion. Sorry about that. Fixed.

index.html Outdated
<p data-lang="zh-hans">尽管书籍仅使用一种体裁,在实际页面的设计上,如目录、索引等页面,会基于基本排版体裁重新设计。索引等页面采用不同排版体裁设计的案例也相当多,直排书索引也会以横排或者多栏排版等方式设计。但在设计上,版面尺寸等依然不出基础排版体裁。</p>
<p data-lang="zh-hant">儘管書籍僅使用一種體裁,在實際頁面的設計上,如目錄、索引等頁面,會基於基本排版體裁重新設計。索引等頁面採用不同排版體裁設計的案例也相當多,直排書索引也會以橫排或者多欄排版等方式設計。但在設計上,版面尺寸等依然不出基礎排版體裁。</p>
<p data-lang="en">Magazines usually contain various kinds of content, which naturally leads to various designs of templates, different sizes of characters, and varying numbers of columns. </p>
<p data-lang="en">Magazines usually contain various kinds of content, which naturally leads to a varity of template designs, different sizes of characters, and varying numbers of columns. </p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'varity'->'variety'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

index.html Outdated
@@ -812,7 +812,7 @@ <h6 data-lang="zh-hant">發表對本文檔的建議</h6>
</li>
</ol>
<div class="note">
<p data-lang="en">In most cases the type area is set at the horizontal and vertical center of the trim size, and then it can be adjusted depending on its dimensions. This design method is mainly inherited from the letter press printing technology. For desktop publishing, the dimensions of the type area are usually calculated based on the space between the type area and the trim size.</p>
<p data-lang="en">In most cases the type area is set at the horizontal and vertical center of the trim size, it can then be adjusted depending on its dimensions. This design method is mainly inherited from letter press printing technology. For desktop publishing, the dimensions of the type area are usually calculated based on the space between the type area and the trim size.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'it can then be'-> 'and can then be' ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

@r12a r12a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of useful edits here. Just one or two comments from me.

index.html Outdated
@@ -370,11 +370,11 @@ <h6 data-lang="zh-hant">發表對本文檔的建議</h6>
<p data-lang="zh-hans">汉字依行排列文字,原则上文字外框彼此紧贴配置,称作密排。</p>
<p data-lang="zh-hant">漢字依行排列文字,原則上文字外框彼此緊貼配置,稱作密排。</p>
<div class="note">
<p data-lang="en" class="checkme">Unlike the letterpress printing era, when several sizes of the original pattern of a letter were required to create matrices, in today's digital era the same original pattern is used for any size simply by enlargement or reduction. Because of this, it might be necessary to adjust the inter-character space when composing lines at large character sizes. When composing lines at small character sizes in outline fonts, hinting data is used to ensure that the width of the strokes that make up a character look correct. When only a small portion of the fonts are smaller, they will be displayed in bitmaps, and there is no need to make extra adjustments.</p>
<p data-lang="en" class="checkme">Unlike the letterpress printing era, when several sizes of the original pattern of a letter were required to create matrices, in today's digital era, the same original pattern can be used for any size simply by enlargement or reduction. Because of this, it might be necessary to adjust inter-character spacing when composing lines at large character sizes. When composing lines at small character sizes in outline fonts, hinting data is used to ensure that the width of the strokes that make up a character look correct. When only a small portion of the fonts are smaller, they will be displayed in bitmaps, and there is no need to make extra adjustments.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

letterpress printing → movable type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too sure about this one. Re-read the Chinese version again and came up with this:
"From the advent of moveable type, each character was set to be flush with one another without any gaps, regardless of vertical or horizontal writing mode. However back then, several sizes of the original pattern of a letter were required to create matrices,"

index.html Outdated
@@ -325,7 +325,7 @@ <h6 data-lang="zh-hant">發表對本文檔的建議</h6>
<p data-lang="en">Chinese characters include Traditional Chinese and Simplified Chinese alternatives. The former is commonly used in Taiwan, Hong Kong and Macao while the latter is commonly used in Mainland China, Singapore and Malaysia.</p>
<p data-lang="zh-hans">依照各地的通行标准,中文所使用的汉字主要分为繁体字与简体字。前者又称正体字、传统汉字等,主要通行于台湾、香港、澳门等地;后者又作简化字,主要通行于中国大陆、星马地区。本文依笔画多寡与部件结构为区别,统称为繁体字与简体字。</p>
<p data-lang="zh-hant">依照各地的通行標準,中文所使用的漢字主要分為繁體字與簡體字。前者又作正體字、傳統漢字等,主要通行於台灣、香港、澳門等地;後者又作簡化字,主要通行於中國大陸、星馬地區。本文依筆畫多寡與部件結構為區別,統稱為繁體字與簡體字。</p>
<p data-lang="en">Different glyphs are used in different regions. One Unicode code point of a Chinese character may have more than one valid glyph, depending on operating systems and typefaces. The focus of this document is Chinese composition and will not discuss more about glyph variations.</p>
<p data-lang="en">Different glyphs are used in different regions. One Unicode code point of a Chinese character may have more than one valid glyph, depending on operating system and typeface used. The focus of this document is Chinese composition and will not discuss cover glyph variations in detail.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discuss cover?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@huijing
Copy link
Contributor Author

huijing commented Apr 3, 2017

I apologise but my latest commit to address #141 ended up in this pull request as well. Please let me know if I need to make further changes before this pull request can be accepted.

@ethantw
Copy link
Member

ethantw commented Apr 3, 2017

@huijing: If it’s possible, I suggest you cherry-pick the commit of the table format adjustments to another branch, and use force push to recover this PR to its previous state. So we can merge this pull request ASAP.

@huijing
Copy link
Contributor Author

huijing commented Apr 3, 2017

@ethantw Ok, I've done that. The table format adjustments have been moved to another branch.

@ethantw ethantw merged commit 68a3425 into w3c:gh-pages Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants