Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note for line length #608

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

Conversation

huijing
Copy link
Contributor

@huijing huijing commented Feb 22, 2024

Closes #555


Preview | Diff

@huijing huijing requested a review from xfq February 22, 2024 11:35
Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for clreq ready!

Name Link
🔨 Latest commit 4834372
🔍 Latest deploy log https://app.netlify.com/sites/clreq/deploys/6656973742f74600088a4521
😎 Deploy Preview https://deploy-preview-608--clreq.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xfq
Copy link
Member

xfq commented Mar 5, 2024

Thank you for the PR!

Two editorial comments:

  • List elements need p elements inside them, and link anchors must go on the li tag. Ref.
  • In our current convention, we do not manually add spaces between Chinese text and Arabic numerals, so please remove them.

@r12a
Copy link
Contributor

r12a commented Mar 5, 2024

@huijing it's a while since i worked on the clreq source so, to refresh my memory, i reorganised the markup as i think it should be. This may save you some work. It's key, i think, to keep the short translated items together. This helps with translation, but also helps avoid situations where language filtering markup is overlooked (as it was in your original for the zh-hans list).

 <div class="note" id="n008">
            <p its-locale-filter-list="en" lang="en">Due to the following reasons, the line length must be an integral multiple of the font size:</p>
            <p its-locale-filter-list="zh-hans" lang="zh-hans">基于下述理由,行长必须为文字尺寸的整数倍:</p>
            <ol>
              <li>
              <p its-locale-filter-list="en" lang="en">The basic principle of Chinese typesetting is, with the exception of the last line of a paragraph, the end of every line should be aligned with each other.</p>
              <p its-locale-filter-list="zh-hans" lang="zh-hans">中文排版的基本原则是,除段落最后一行以外,每行行尾应对齐。</p>
              <p its-locale-filter-list="zh-hant" lang="zh-hant">中文排版的基本原則是,除段落最後一行以外,每行行尾應對齊。</p>
              </li>
              <li>
              <p its-locale-filter-list="en" lang="en">All characters used in Chinese typesetting (including Han characters and punctuation) are square characters.</p>
              <p its-locale-filter-list="zh-hans" lang="zh-hans">中文排版所用的文字(包括汉字、标点),其字框的设计原则是正方形。</p>
              <p its-locale-filter-list="zh-hant" lang="zh-hant">中文排版所用的文字(包括漢字、標點),其字框的設計原則是正方形。</p>
              </li>
              <li>
              <p its-locale-filter-list="en" lang="en">Characters in Chinese typesetting are set solid.</p>
              <p its-locale-filter-list="zh-hans" lang="zh-hans">中文排版的排字原则是,文字应为密排。</p>
              <p its-locale-filter-list="zh-hant" lang="zh-hant">中文排版的排字原則是,文字應爲密排。</p>
              </li>
            </ol>
            <p its-locale-filter-list="en" lang="en">As a basic principle, the line length should be set according to the actual conditions, which could be the usage of different fonts, design of the type area, trim size or media types. Generally, the line length for newspapers and periodicals is relatively shorter, while the line length for books is longer. For the sake of reference, most books have line lengths of body text in the range between 17 to 40 characters. To prevent excessive line breaks that could cause difficulty in reading, the line length of body text should not be less than 10 characters. For horizontal writing mode, the line length of body copy should not exceed 48 characters. For vertical writing mode, the line length of body copy should not exceed 55 characters.</p>
            <p its-locale-filter-list="zh-hans" lang="zh-hans">作为总体原则,行长应依照不同字体、版式、成品尺寸以及媒介种类、根据实际情况设置。一般来说,报纸期刊的行长相对较短,而书籍的行长较长,但作为参考值,大多数书籍的正文行长一般设在 17 到 40 字范围区间。为避免阅读时频繁换行、串行等情况,正文行长最小不宜少于 10 字、而横排最大行长不宜长于 48 字、竖排不宜长于 55 字。</p>
            <p its-locale-filter-list="zh-hant" lang="zh-hant">作爲總體原則,行長應依照不同字體、版式、成品尺寸以及媒介種類、根據實際情況設置。一般來說,報紙期刊的行長相對較短,而書籍的行長較長,但作爲參考值,大多數書籍的正文行長一般設在 17 到 40 字範圍區間。爲避免閱讀時頻繁換行、串行等情況,正文行長最小不宜少於 10 字、而橫排最大行長不宜長於 48 字、豎排不宜長於 55 字。</p>

@huijing
Copy link
Contributor Author

huijing commented May 29, 2024

Updated the markup as per @r12a's recommendation.

@xfq
Copy link
Member

xfq commented Jun 6, 2024

@huijing Thanks! Please remove the manually add spaces between Chinese text and Arabic numerals. Otherwise LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Best line length
3 participants