-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note for line length #608
Conversation
✅ Deploy Preview for clreq ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for the PR! Two editorial comments:
|
@huijing it's a while since i worked on the clreq source so, to refresh my memory, i reorganised the markup as i think it should be. This may save you some work. It's key, i think, to keep the short translated items together. This helps with translation, but also helps avoid situations where language filtering markup is overlooked (as it was in your original for the zh-hans list).
|
361385d
to
4834372
Compare
Updated the markup as per @r12a's recommendation. |
@huijing Thanks! Please remove the manually add spaces between Chinese text and Arabic numerals. Otherwise LGTM. |
Merging. Thanks a lot! |
Closes #555
Preview | Diff