Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Role Section #117

Closed
wants to merge 11 commits into from
Closed

Generic Role Section #117

wants to merge 11 commits into from

Conversation

cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook commented May 6, 2022

Adds a new section: 4.4.3 Role Mapping for Generic Host Language Elements.

Submitted early for feedback before continuing.

This may eventually Resolve #112.

Preview of generic role section


Preview | Diff

… a new section: 4.4.3 Role Mapping for Generic Host Language Elements
@cookiecrook cookiecrook marked this pull request as ready for review May 6, 2022 00:20
@cookiecrook
Copy link
Contributor Author

This is the approach @scottaohara and I talked about Monday, but I'd like @aleventhal's feedback first, then other implementors, before spending more time on this direction. Thanks.

@cookiecrook
Copy link
Contributor Author

The main mappings tables (from Core-AAM, as well as HTML-AAM,SVG-AAM, etc.) could cross-link to this new section. For example, html:bdo would map to ~"generic, with relevant text direction mapping" or something similar.

Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cookiecrook Thank you for this. I added various suggestions (again, assuming others want to move forward with this direction. FWIW I like it), including mappings for the generic span/text-level examples. As these had some variability in HTML AAM I took a generalized approach to their inclusion here.

Added some more info to the intro about generic elements - specifically adding new content to expand on the 'earlier versions of html' sentence, since the sentence read to me as if this was a problem with earlier html, but more modern HTML doesn't have these anymore. If you don't think this is needed, then we can cut that.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@spectranaut spectranaut self-requested a review May 10, 2022 17:36
cookiecrook and others added 8 commits June 23, 2022 13:41
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor language fixes

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Co-authored-by: Valerie Young <spectranaut@gmail.com>
Copy link
Contributor Author

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making sure Scott's diff suggestion made it in. Separated because there was a conflict with the typo correction already included.

index.html Outdated Show resolved Hide resolved
Comment on lines +2330 to +2336
<tr id="role-map-generic-text-style">
<th>more needed…</th>
<td class="role-msaa-ia2"></td>
<td class="role-uia"></td>
<td class="role-atk"></td>
<td class="role-axapi"></td>
</tr>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a minute. I think row is extraneous and can be pulled out?

</tr>
</thead>
<tbody>
<tr id="role-map-generic-bikeshed"><!-- change 'bikeshed' here to soemthing other than CSS 'block' so as to not conflate the style property values with the layout concept -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably have been a draft PR.

<span class="property">AXSubrole: <code>&lt;nil&gt;</code></span><br />
</td>
</tr>
<tr id="role-map-generic-">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another bikeshed ID: "role-map-generic-???". Commenting so I won't forget about this b/c it's been too long.

Comment on lines +2283 to +2285
<div class="ednote" style="border: solid 2px red;">
<p>The following table won't be close to accurate in the first draft PR. I'm listing these out to solicit feedback from implementors as to whether this approach is reasonable for documenting various mappings for the generic role.</p>
</div>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long is too long to wait?

Suggested change
<div class="ednote" style="border: solid 2px red;">
<p>The following table won't be close to accurate in the first draft PR. I'm listing these out to solicit feedback from implementors as to whether this approach is reasonable for documenting various mappings for the generic role.</p>
</div>

@spectranaut
Copy link
Contributor

Todo: close after hearing from @cookiecrook and assigning reviewers to new PR: w3c/aria#2203 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change mapping for generic
4 participants