Update annotation roles AXAPI mapping #137
Conversation
spectranaut
force-pushed
the
axapi-annotation
branch
from
35681ea
to
ebf92fb
Compare
| @@ -736,6 +736,7 @@ <h3>Role Mapping Table</h3> | |||
| <td class="role-axapi"> | |||
| <span class="property">AXRole: <code>AXGroup</code></span><br /> | |||
| <span class="property">AXSubrole: <code>AXDeleteStyleGroup</code></span><br /> | |||
| <span class="property">AXAttributedStringForTextMarkerRange: contains <code>AXIsSuggestedDeletion = 1;</code> for all text contained in a <code>deletion</code></span> | |||
There was a problem hiding this comment.
@cookiecrook I'd say the the terminology AXIsSuggestedDeletion/Insertion are a misnomer, because suggestions are only one use case. The insertion/deletion markup is useful for marking up a diff/history of a file. It's an insertion or deletion from the past.
There was a problem hiding this comment.
this is what webkit exposes, just to have the link on hand: https://github.com/WebKit/WebKit/blob/335a5587c31289a3a8043e4c460f7488c59e947b/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm#L855
There was a problem hiding this comment.
+1 but I'd like @cookiecrook to look at my comment about the naming of AXIsSuggested[Insertion|Deletion]. It's find as long as it doesn't reach the user, because it would be weird e.g for a VoiceOver user to hear that when reading a diff with the current version of a doc and an older version.
|
Checking with others... If I understand your point, you're stating "suggested" should never be exposed to the screen reader as user-presented speech or braille, but you don't care whether it remains in the non-user-presented key. Is that right? |
|
Right, I think there are plenty of misnomers or confusing parts of various APIs. It's not ideal, but that's up to you to decide if it's worth the effort to deprecate or change it. The real problem is if user's hear something is suggested when it's just reporting that something was historically inserted or removed when comparing versions. |
|
Filed WebKit bug here. https://webkit.org/b/245546 Intention is to keep the current API working in perpetuity, so no reason to hold off implementing the existing API. |
SHA: e48a618 Reason: push, by spectranaut Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Brought to my attention in: https://bugs.chromium.org/p/chromium/issues/detail?id=1359005
We have never documented
AXAttributedStringForTextMarkerRange-- but it looks like it is typically used for surfacing CSS attributes.Preview | Diff