Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update UIA ins/del #163

Merged
merged 1 commit into from
May 8, 2023
Merged

update UIA ins/del #163

merged 1 commit into from
May 8, 2023

Conversation

stevefaulkner
Copy link
Contributor

@stevefaulkner stevefaulkner commented Jan 16, 2023

Closes #162

Updating values to reflect implementation

When tested with Edge on windows version 109.0.1518.55

LocalizedControlType: "insertion" and LocalizedControlType: "deletion"

currently listed in core AAM as
LocalizedControlType: "ins" and LocalizedControlType: "del"


Preview | Diff

@spectranaut
Copy link
Contributor

Thanks for this! Here is a WPT test update: web-platform-tests/wpt#38301

@benbeaudry
Copy link
Contributor

benbeaudry commented Feb 2, 2023

Can we hold off a bit more before merging this PR? I'm awaiting a response from the Narrator and UIA teams. I'll get an answer tomorrow. I just want to validate what are the expectations.

@benbeaudry
Copy link
Contributor

@stevefaulkner Thanks for your patience! UIA uses "Insertion Change" and "Deletion Change" as localized control types for ins and del. However, Chromium and Edge would prefer to keep exposing this one as "insertion" and "deletion" since it's shorter.

I believe the CoreAAM should reflect the UIA value rather than the Chromium/Edge. We do not plan to match this value, though.

Thanks for putting this together.

@spectranaut
Copy link
Contributor

I believe the CoreAAM should reflect the UIA value rather than the Chromium/Edge. We do not plan to match this value, though.

hey @benbeaudry gotta say I'm a bit confused, shouldn't Chromium/Edge follow the UIA expectation? Will the appropriate information still get to assistive technologies who use UIA if Chromium/Edge surface "insertion" instead of "Insertion Change"?

@spectranaut spectranaut merged commit 8404557 into main May 8, 2023
github-actions bot added a commit that referenced this pull request May 8, 2023
SHA: 8404557
Reason: push, by spectranaut

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UIA mappings for insertion/deletion have incorrect values
3 participants