Remove UIA_DescribedBy property from aria-describedby UIA mappings #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 23, 2023
According to w3c/core-aam#205, aria-details should map to the DescribedBy UIA property. Currently, only aria-describedby maps to that property. This change maps aria-details to DescribedBy and removes the mapping of aria-describedby to DescribedBy. Fixed: 1492553 AX-Relnotes: aria-details will be exposed by DesribedBy for UIA users Change-Id: I7d484998855681e989bfc26606646e57c44d9e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4935457 Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1213742}
scottaohara
approved these changes
Oct 25, 2023
|
@spectranaut for merging when you'll get a chance :) |
|
Test update: web-platform-tests/wpt#42784 |
spectranaut
approved these changes
Oct 26, 2023
|
You are the source of truth on the things now, @benbeaudry :) |
github-actions bot
added a commit
that referenced
this pull request
Oct 26, 2023
) SHA: 8def608 Reason: push, by spectranaut Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #204
The UIA_DescribedBy property actually maps more closely to the definition of aria-details than it does the one of aria-describedby. In this PR, we remove any mention of the UIA_DescribedBy property in the UIA mappings of the aria-describedby attribute.
Chromium will fully reflect this updated mapping (and the current UIA mapping of aria-details) as soon as https://chromium-review.googlesource.com/c/chromium/src/+/4935457 merges.
Preview | Diff