Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UIA alert event in role mapping table to match UIA changes #229

Closed
wants to merge 1 commit into from

Conversation

smhigley
Copy link
Contributor

@smhigley smhigley commented Apr 25, 2024

Based on screen reader feedback, the alert role no longer fires a system alert event, but a live region changed event (still on insertion).

Related Chromium PR with the change: https://chromium-review.googlesource.com/c/chromium/src/+/3715513


Preview | Diff

Copy link
Contributor

@benbeaudry benbeaudry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benbeaudry benbeaudry self-requested a review April 26, 2024 23:35
@benbeaudry
Copy link
Contributor

Actually, we will change this behavior in Chrome. I discussed your idea of not firing alerts when the content of the alert is empty with James Craig and Aaron this morning and they both agreed it would be a welcomed improvement to the spec. I'll implement this change in Chromium.

I filed https://issues.chromium.org/issues/337315124 and https://issues.chromium.org/issues/337315123 to change the Chromium behavior. Thanks again!

@douggeoffray
Copy link

douggeoffray commented Apr 26, 2024 via email

@smhigley
Copy link
Contributor Author

smhigley commented May 7, 2024

Discussed this internally, and instead of going this route Edge is going to revert to alert event mappings but not fire events for empty alerts.

@smhigley smhigley closed this May 7, 2024
@douggeoffray
Copy link

douggeoffray commented May 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants