Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-typed-om] CSSNumericValue.to could return a CSSUnitValue #525

Closed
darrnshn opened this issue Dec 3, 2017 · 2 comments
Closed

[css-typed-om] CSSNumericValue.to could return a CSSUnitValue #525

darrnshn opened this issue Dec 3, 2017 · 2 comments
Labels
css-typed-om-1 Needs Edits

Comments

@darrnshn
Copy link
Collaborator

darrnshn commented Dec 3, 2017

A bit of a nit :) The return type of CSSNumericValue.to is currently CSSNumericValue, but I think we could change it to CSSUnitValue. I only raised this issue for consistency since CSSNumericValue.toSum returns a CSSMathSum and not a CSSNumericValue.
@tabatkins
Copy link
Member

Agreed.

@darrnshn darrnshn mentioned this issue Dec 7, 2017
Merged
MXEBot pushed a commit to mirror/chromium that referenced this issue Jan 12, 2018
@hwanseung
[css-typed-om] CSSNumericValue.to should return CSSUnitValue
1464e1e 
CSSNumericValue.toSum returns a CSSMathSum and not a CSSNumericValue.
so CSSNumericValue.to should return CSSUnitValue for consistency.

w3c/css-houdini-drafts#525

Bug: 800927
Change-Id: I8fe800f224367943a060e8ef422405f8007eaa77
Reviewed-on: https://chromium-review.googlesource.com/861690
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#528861}
@nainar
Copy link
Contributor

nainar commented Jan 23, 2018

Fixed by #527

@nainar nainar closed this as completed Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-typed-om-1 Needs Edits
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tabatkins @nainar @darrnshn