Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-typed-om] Should CSSTransformComponent have a toMatrix()? #609

Closed
dbaron opened this issue Jan 30, 2018 · 2 comments
Closed

[css-typed-om] Should CSSTransformComponent have a toMatrix()? #609

dbaron opened this issue Jan 30, 2018 · 2 comments
Labels
css-typed-om-1

Comments

@dbaron
Copy link
Member

dbaron commented Jan 30, 2018

Reading the definition of CSSTransformValue.toMatrix() made me wonder if CSSTransformComponent should also have a toMatrix() that works the same way. It seems like it would make sense.
@darrnshn
Copy link
Collaborator

I think it's a good idea; it would be equivalent to new CSSTransformValue([component]).toMatrix(), so there shouldn't be any problems.

@tabatkins
Copy link
Member

Yeah, makes sense.

@darrnshn darrnshn mentioned this issue Jan 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-typed-om-1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbaron @tabatkins @darrnshn