Add CSSTransformComponent.toMatrix #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrnshn
commented
Jan 31, 2018
| 2. Set |matrix| to the result of multiplying |matrix| | ||
| and |funcMatrix|. | ||
| 3. If |func|’s {{CSSTransformComponent/is2D}} internal slot is `false`, | ||
| and the matrix represented by |funcMatrix|. |
There was a problem hiding this comment.
Can I just multiply two DOMMatrix together and will it correctly handle is2D?
|
Slightly rewrote to simplify is2D handling. To answer your comment: yes, DOMMatrix multiplication automatically handles is2D for you. I was doing manual handling of is2D before because I was working with abstract matrixes instead. |
darrnshn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #609 .
Hi @tabatkins , PTAL