Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type checking to CSSNumericValue.parse #1065

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Add type checking to CSSNumericValue.parse #1065

merged 1 commit into from
Jan 28, 2022

Conversation

xiaochengh
Copy link
Contributor

Fixes #1064

@xiaochengh
Copy link
Contributor Author

@tabatkins PTAL

@tabatkins tabatkins merged commit 4fd00fb into w3c:main Jan 28, 2022
@xiaochengh xiaochengh deleted the patch-1 branch January 28, 2022 19:40
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Jan 28, 2022
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 28, 2022
@xiaochengh @chromium-wpt-export-bot
Add <dimension-token> type-checking to CSSNumericValue::parse()
fd846bd 
This patch implements a recent spec bug fix:

w3c/css-houdini-drafts#1065

Fixed: 1291603
Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91
aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 31, 2022
@xiaochengh
Add <dimension-token> type-checking to CSSNumericValue::parse()
1e12a4f 
This patch implements a recent spec bug fix:

w3c/css-houdini-drafts#1065

Fixed: 1291603
Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#965351}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 31, 2022
@xiaochengh @chromium-wpt-export-bot
Add <dimension-token> type-checking to CSSNumericValue::parse()
58d0793 
This patch implements a recent spec bug fix:

w3c/css-houdini-drafts#1065

Fixed: 1291603
Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#965351}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 31, 2022
@xiaochengh @chromium-wpt-export-bot
Add <dimension-token> type-checking to CSSNumericValue::parse()
9c33821 
This patch implements a recent spec bug fix:

w3c/css-houdini-drafts#1065

Fixed: 1291603
Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#965351}
mattwoodrow pushed a commit to mattwoodrow/wpt that referenced this pull request Feb 15, 2022
@xiaochengh @mattwoodrow
Add <dimension-token> type-checking to CSSNumericValue::parse()
bd78e8a 
This patch implements a recent spec bug fix:

w3c/css-houdini-drafts#1065

Fixed: 1291603
Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#965351}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 26, 2022
@xiaochengh @moz-wptsync-bot
Bug 1752634 [wpt PR 32603] - Add <dimension-token> type-checking to C…
2a3717e 
…SSNumericValue::parse(), a=testonly

Automatic update from web-platform-tests
Add <dimension-token> type-checking to CSSNumericValue::parse()

This patch implements a recent spec bug fix:

w3c/css-houdini-drafts#1065

Fixed: 1291603
Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#965351}

--

wpt-commits: 9c338218c44d4c52f0affc32025fd847b7985f92
wpt-pr: 32603
DanielRyanSmith pushed a commit to DanielRyanSmith/wpt that referenced this pull request Feb 28, 2022
@xiaochengh @DanielRyanSmith
Add <dimension-token> type-checking to CSSNumericValue::parse()
665a3ac 
This patch implements a recent spec bug fix:

w3c/css-houdini-drafts#1065

Fixed: 1291603
Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#965351}
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Mar 1, 2022
@xiaochengh @moz-wptsync-bot
Bug 1752634 [wpt PR 32603] - Add <dimension-token> type-checking to C…
f94fb52 
…SSNumericValue::parse(), a=testonly

Automatic update from web-platform-tests
Add <dimension-token> type-checking to CSSNumericValue::parse()

This patch implements a recent spec bug fix:

w3c/css-houdini-drafts#1065

Fixed: 1291603
Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#965351}

--

wpt-commits: 9c338218c44d4c52f0affc32025fd847b7985f92
wpt-pr: 32603
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 8, 2022
@xiaochengh @moz-wptsync-bot
Bug 1752634 [wpt PR 32603] - Add <dimension-token> type-checking to C…
81845ac 
…SSNumericValue::parse(), a=testonly

Automatic update from web-platform-tests
Add <dimension-token> type-checking to CSSNumericValue::parse()

This patch implements a recent spec bug fix:

w3c/css-houdini-drafts#1065

Fixed: 1291603
Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#965351}

--

wpt-commits: 9c338218c44d4c52f0affc32025fd847b7985f92
wpt-pr: 32603
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Mar 8, 2022
@xiaochengh @moz-wptsync-bot
Bug 1752634 [wpt PR 32603] - Add <dimension-token> type-checking to C…
500e3fe 
…SSNumericValue::parse(), a=testonly

Automatic update from web-platform-tests
Add <dimension-token> type-checking to CSSNumericValue::parse()

This patch implements a recent spec bug fix:

w3c/css-houdini-drafts#1065

Fixed: 1291603
Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#965351}

--

wpt-commits: 9c338218c44d4c52f0affc32025fd847b7985f92
wpt-pr: 32603
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
@xiaochengh
Add <dimension-token> type-checking to CSSNumericValue::parse()
3cf6225 
This patch implements a recent spec bug fix:

w3c/css-houdini-drafts#1065

Fixed: 1291603
Change-Id: I3adae8148dd47b24d4516448e492daccce7ecd91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425673
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#965351}
NOKEYCHECK=True
GitOrigin-RevId: 1e12a4f02ed422d28fe7dfd7afe9a3e7cbde762f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[css-typed-om] CSSNumericValue.parse() needs type checking for <dimension-token>
2 participants
@xiaochengh @tabatkins