Add serialization for stroke geometry #459
Conversation
css-typed-om/Overview.bs
Outdated
| @@ -2903,6 +2903,52 @@ depending on the property they came from: | |||
| return "currentcolor". | |||
| 2. Otherwise, return the result of serializing the <<color>> value. | |||
|
|
|||
| : 'stroke-align' | |||
| :: | |||
| 1. If 'stroke-align' is one of the following keywords, | |||
There was a problem hiding this comment.
Removed the if conditions where no other course of action is possible. TAL?
css-typed-om/Overview.bs
Outdated
| 1. Return the string representation of the keyword: | ||
| * center, | ||
| * inset, | ||
| * outset. |
There was a problem hiding this comment.
I don't know that you need to explicitly list the keywords even. Maybe get @tabatkins to take a look.
There was a problem hiding this comment.
Yeah, no need to list these explicitly, it just adds an editting hazard for the future. Just say "return the result of serializing the keyword value".
css-typed-om/Overview.bs
Outdated
| : 'stroke-linejoin' | ||
| :: | ||
| 1. Let |values| initially be the empty [=list=]. | ||
| 2. If 'stroke-linejoin' has one of the following keywords, |
There was a problem hiding this comment.
Instead list the keyword that it can't be (the one that it behaves as if omitted). This avoids us having to update this in the future if we add more keywords. Same for step 3.
css-typed-om/Overview.bs
Outdated
| * bevel, | ||
| * round, | ||
| * stupid. | ||
| 4. Return the result of concatenating all the items in |values|, |
There was a problem hiding this comment.
It might be empty, need to handle that case too (emit the shortest value that triggers the initial-value behavior; check browsers to see what they do).
There was a problem hiding this comment.
@tabatkins I split this PR into two stroke-{align,break,linecap} are in this PR now.
css-typed-om/Overview.bs
Outdated
| 1. Return the string representation of the keyword: | ||
| * center, | ||
| * inset, | ||
| * outset. |
@shans TAL? This should be easy?