Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialization for box-sizing #462

Closed
wants to merge 1 commit into from
Closed

Conversation

nainar
Copy link
Contributor

@nainar nainar commented Aug 22, 2017

@shans PTAL?

@@ -2897,6 +2897,13 @@ depending on the property they came from:
8. Return the result of concatenating all the items in |values|,
separated by " " (U+0020 SPACE).

: 'box-sizing'
::
1. Return the string representation of the keyword:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just serialize the value as a keyword. No need to specify the keywords; it just means we'd have to edit this when new keywords are added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@nainar
Copy link
Contributor Author

nainar commented Oct 16, 2017

@tabatkins I have made the changes you asked for, sorry for the late reply on this. Could you TAL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants