Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-animationworklet] Change state to be a function instead of getter #866

Merged
merged 3 commits into from Mar 11, 2019
Merged

[css-animationworklet] Change state to be a function instead of getter #866

merged 3 commits into from Mar 11, 2019

Conversation

majido
Copy link
Contributor

@majido majido commented Mar 7, 2019

There is no need for state to be a getter rather than a function.

It is simpler to implement and more consistent with animate() for state to also be a function.

stephenmcgruer
stephenmcgruer approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@stephenmcgruer stephenmcgruer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit

css-animationworklet/Overview.bs Outdated Show resolved Hide resolved
@majido majido merged commit 6a95854 into w3c:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmcgruer stephenmcgruer stephenmcgruer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@majido @stephenmcgruer