Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-properties-values-api] Require <custom-ident> as component name. #884

Merged
merged 3 commits into from May 7, 2019
Merged

[css-properties-values-api] Require <custom-ident> as component name. #884

merged 3 commits into from May 7, 2019

Conversation

andruud
Copy link
Member

@andruud andruud commented May 6, 2019

Something like this was in the original syntax parsing PR, but it got
lost at some point.

Resolves #879.

@andruud
[css-properties-values-api] Require <custom-ident> as component name.
ceac93b 
Something like this was in the original syntax parsing PR, but it got
lost at some point.

Resolves w3c#879.
@andruud
Copy link
Member Author

andruud commented May 6, 2019

cc @tabatkins @emilio

@andruud
Copy link
Member Author

andruud commented May 6, 2019

Uhm, oops, that doesn't work, hold on.

@andruud
Copy link
Member Author

andruud commented May 6, 2019

There we go.

tabatkins
tabatkins requested changes May 7, 2019
View reviewed changes
Copy link
Member

@tabatkins tabatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't match strings against productions, have to do a parse on it to turn it into a CSS value.

css-properties-values-api/Overview.bs Outdated Show resolved Hide resolved
@tabatkins @andruud
Update css-properties-values-api/Overview.bs
1bde2da 
Co-Authored-By: andruud <andruud@gmail.com>
@tabatkins tabatkins merged commit b4a12da into w3c:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabatkins tabatkins tabatkins requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@andruud @tabatkins