Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid casting in number -> unit checks #51

Closed
ylafon opened this issue May 8, 2016 · 1 comment
Closed

Avoid casting in number -> unit checks #51

ylafon opened this issue May 8, 2016 · 1 comment

Comments

@ylafon
Copy link
Member

ylafon commented May 8, 2016

avoid casting CssNumber to CssLength or other. Use the CssCheckableValue interface for that.
Also CssColor and potentially other values needs to handle calc() and attr()
ylafon added a commit that referenced this issue May 9, 2016
@ylafon
Changed the way unitless 0 is checked against various types. It was n…
44a427a 
…eeded

for dynamic type checking as the value can't be cast.
See issue #51
ylafon added a commit that referenced this issue May 9, 2016
@ylafon
more changes in the way unitless values (aka 0) are checked, fixing p…
c96d013 
…laces where unitless value was allowed (for time and frequency), See issue #51
@ylafon ylafon mentioned this issue Jul 28, 2018
Closed
@ylafon
Copy link
Member Author

ylafon commented Sep 29, 2021

fixed in css3 by the introduction of var and shifting types

@ylafon ylafon closed this as completed Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ylafon