Skip to content

Commit

Permalink
[css-rhythm] Revert the addition of 'none' to 'line-height-step'
Browse files Browse the repository at this point in the history
As per the discussion in #1151. The reason we added is gone, and we can add it back if the reason came back.
  • Loading branch information
kojiishi committed Nov 13, 2017
1 parent b8ac85c commit b752cd9
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions css-rhythm-1/Overview.bs
Original file line number Diff line number Diff line change
Expand Up @@ -350,14 +350,14 @@ Adjusting Line Box Heights: the 'line-height-step' property {#line-height-step}

<pre class='propdef'>
Name: line-height-step
Value: none | <<length>>
Initial: none
Value: <<length>>
Initial: 0
Applies to: block containers
Inherited: yes
Animatable: no
Percentages: N/A
Media: visual
Computed Value: the absolute length, 0 for none
Computed Value: the absolute length
</pre>

This property defines the <dfn>step unit</dfn> for line box heights.
Expand Down Expand Up @@ -392,7 +392,6 @@ by making heights of all lines an integer multiple of the <a>step unit</a>.
<p class="caption">Rounding up the computed line box height.
</div>

<div class="issue">''line-height-step/none'' and ''0'' are equivalent. Is this ok?</div>
<div class="issue">Should this be animatable?
There doesn't seem to be use cases but needed for consistency?</div>

Expand Down

0 comments on commit b752cd9

Please sign in to comment.