Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-anchor-position] Initial value of position-anchor should be auto not implicit #10312

Open
fantasai opened this issue May 13, 2024 · 7 comments
Open

[css-anchor-position] Initial value of position-anchor should be auto not implicit #10312

fantasai opened this issue May 13, 2024 · 7 comments
Labels
Closed Accepted by CSSWG Resolution css-anchor-position-1 Needs Edits

Comments

@fantasai
Copy link
Collaborator

The syntax of position-anchor is <dashed-ident> | implicit with the initial value being implicit. “Implicit” is a great spec word, but it is fairly advanced vocabulary and not a term we have put into the authoring syntax space before. The typical keyword for this kind of thing in CSS is auto. We should rename it to auto.
@mfreed7
Copy link

mfreed7 commented May 13, 2024

This is a reasonable point. +1 to renaming implicit to auto. Let’s get a resolution on Wednesday if possible. Chromium is happy to ship this change, ASAP.

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 14, 2024
@chromium-wpt-export-bot
Rename position-anchor:implicit to position-anchor:auto
9042634 
See the spec discussion here:

w3c/csswg-drafts#10312 (comment)

This is observable, but barely. After this CL, `implicit` won't be a
valid value for `position-anchor`, so it'll resolve to the default
value of `auto`. Meaning the behavior will be the same. But via the
CSSOM, getComputedStyle(element).positionAnchor will now return "auto"
instead of "implicit".

Fixed: 340206288
Change-Id: I75b05310638dca70aa6aa8807da8cfe7c9624a32
Merged
@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed [css-anchor-position] Initial value of `position-anchor` should be `auto` not `implicit` , and agreed to the following:

  • RESOLVED: Rename implicit to auto in position-anchor
  • RESOLVED: Drop the keyword from the anchor() function
The full IRC log of that discussion <bradk> present*
<emilio> fantasai: The initial value of `position-anchor` is `implicit`
<emilio> ... advanced vocabulary, but we probably don't want to expose this to authors
<emilio> ... propose to rename `implicit` to `auto`
<emilio> ... and then this keyword also shows up in `anchor()` where we can rename it to `auto` too or just drop it because I don't think it's necessary
<emilio> TabAtkins: we should just drop it, if you omit it you get that behavior
<emilio> ... I generally want to make sure that implicit behavior is specifiable, but not necessary
<emilio> florian: seems more consistent to how we name things
<emilio> RESOLVED: Rename implicit to auto in position-anchor
<emilio> RESOLVED: Drop the keyword from the anchor() function

@mozilla-apprentice mozilla-apprentice mentioned this issue May 15, 2024
Closed
@chromium-helper chromium-helper mentioned this issue May 15, 2024
Closed
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 15, 2024
@chromium-wpt-export-bot
Rename position-anchor:implicit to position-anchor:auto
9539feb 
This was resolved here:

w3c/csswg-drafts#10312 (comment)

and will be added to the spec shortly.

This is observable, but barely. After this CL, `implicit` won't be a
valid value for `position-anchor`, so it'll resolve to the default
value of `auto`. Meaning the behavior will be the same. But via the
CSSOM, getComputedStyle(element).positionAnchor will now return "auto"
instead of "implicit".

Fixed: 340206288
Change-Id: I75b05310638dca70aa6aa8807da8cfe7c9624a32
aarongable pushed a commit to chromium/chromium that referenced this issue May 15, 2024
Rename position-anchor:implicit to position-anchor:auto
3e12163 
This was resolved here:

w3c/csswg-drafts#10312 (comment)

and will be added to the spec shortly.

This is observable, but barely. After this CL, `implicit` won't be a
valid value for `position-anchor`, so it'll resolve to the default
value of `auto`. Meaning the behavior will be the same. But via the
CSSOM, getComputedStyle(element).positionAnchor will now return "auto"
instead of "implicit".

Fixed: 340206288
Change-Id: I75b05310638dca70aa6aa8807da8cfe7c9624a32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540275
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301585}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 15, 2024
@chromium-wpt-export-bot
Rename position-anchor:implicit to position-anchor:auto
05d3f03 
This was resolved here:

w3c/csswg-drafts#10312 (comment)

and will be added to the spec shortly.

This is observable, but barely. After this CL, `implicit` won't be a
valid value for `position-anchor`, so it'll resolve to the default
value of `auto`. Meaning the behavior will be the same. But via the
CSSOM, getComputedStyle(element).positionAnchor will now return "auto"
instead of "implicit".

Fixed: 340206288
Change-Id: I75b05310638dca70aa6aa8807da8cfe7c9624a32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540275
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301585}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 15, 2024
@chromium-wpt-export-bot
Rename position-anchor:implicit to position-anchor:auto
6bdb665 
This was resolved here:

w3c/csswg-drafts#10312 (comment)

and will be added to the spec shortly.

This is observable, but barely. After this CL, `implicit` won't be a
valid value for `position-anchor`, so it'll resolve to the default
value of `auto`. Meaning the behavior will be the same. But via the
CSSOM, getComputedStyle(element).positionAnchor will now return "auto"
instead of "implicit".

Fixed: 340206288
Change-Id: I75b05310638dca70aa6aa8807da8cfe7c9624a32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540275
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301585}
tabatkins added a commit that referenced this issue May 15, 2024
@tabatkins
[css-anchor-position-1] Change position-anchor initial value to 'auto…
f5da764 
…', and only let you specify that behavior in anchor()/anchor-size() via omission. #10312
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 15, 2024
@chromium-wpt-export-bot
Remove auto value from anchor() function
bee1296 
See the CSSWG resolution here:

w3c/csswg-drafts#10312 (comment)

which says:

RESOLVED: Rename implicit to auto in position-anchor
RESOLVED: Drop the keyword from the anchor() function

The first part was taken care of in [1]. This CL takes care of
the second part.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5540275

Bug: 340206288
Change-Id: I33972e06104d061bb06232dac851877159b4fc92
Merged
@yisibl
Copy link
Contributor

yisibl commented May 16, 2024

Is the implicit value also removed from anchor-size()?

Until then, anchor-size(implicit width) is a legal value.

yisibl added a commit to cssdream/css3test that referenced this issue May 16, 2024
@yisibl
fix: update the syntax of anchor() and anchor-size()
5c85a53 
see: w3c/csswg-drafts#10312 (comment)
@yisibl yisibl mentioned this issue May 16, 2024
Merged
@astearns
Copy link
Member

@yisibl the syntax change looks right to me (see the change in the <anchor-element> component definition)

But there are still several prose references to an implicit keyword that should be removed (in 2.1.1 and 2.3)

@astearns astearns reopened this May 16, 2024
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 16, 2024
@chromium-wpt-export-bot
Remove auto value from anchor() function
9c13d19 
See the CSSWG resolution here:

w3c/csswg-drafts#10312 (comment)

which says:

RESOLVED: Rename implicit to auto in position-anchor
RESOLVED: Drop the keyword from the anchor() function

The first part was taken care of in [1]. This CL takes care of
the second part.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5540275

Bug: 340206288
Change-Id: I33972e06104d061bb06232dac851877159b4fc92
@yisibl
Copy link
Contributor

yisibl commented May 16, 2024

@astearns So after the syntax change, will anchor-size(implicit width) become anchor-size(width) ?

@astearns
Copy link
Member

@yisibl that is my reading. @tabatkins are we correct?

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 17, 2024
@chromium-wpt-export-bot
Remove auto value from anchor() function
49c50bd 
See the CSSWG resolution here:

w3c/csswg-drafts#10312 (comment)

which says:

RESOLVED: Rename implicit to auto in position-anchor
RESOLVED: Drop the keyword from the anchor() function

The first part was taken care of in [1]. This CL takes care of
the second part.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5540275

Bug: 340206288
Change-Id: I33972e06104d061bb06232dac851877159b4fc92
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 17, 2024
@chromium-wpt-export-bot
Remove auto value from anchor() function
0cb9503 
See the CSSWG resolution here:

w3c/csswg-drafts#10312 (comment)

which says:

RESOLVED: Rename implicit to auto in position-anchor
RESOLVED: Drop the keyword from the anchor() function

The first part was taken care of in [1]. This CL takes care of
the second part.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5540275

Bug: 340206288
Change-Id: I33972e06104d061bb06232dac851877159b4fc92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5542337
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1302830}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 17, 2024
@chromium-wpt-export-bot
Remove auto value from anchor() function
e9d9b03 
See the CSSWG resolution here:

w3c/csswg-drafts#10312 (comment)

which says:

RESOLVED: Rename implicit to auto in position-anchor
RESOLVED: Drop the keyword from the anchor() function

The first part was taken care of in [1]. This CL takes care of
the second part.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5540275

Bug: 340206288
Change-Id: I33972e06104d061bb06232dac851877159b4fc92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5542337
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1302830}
LeaVerou pushed a commit to LeaVerou/css3test that referenced this issue May 22, 2024
@yisibl
fix: update the syntax of anchor() and anchor-size() (#248)
5fcb658 
* fix: update the syntax of anchor() and anchor-size()

see: w3c/csswg-drafts#10312 (comment)

* Add anchor-center to 'place-self' and 'place-items'

* Add more

* Add more logical size properties to anchor-size()

* fix: reomve anchor(auto)
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 23, 2024
@moz-wptsync-bot
Bug 1896778 [wpt PR 46269] - Rename position-anchor:implicit to posit…
014a60d 
…ion-anchor:auto, a=testonly

Automatic update from web-platform-tests
Rename position-anchor:implicit to position-anchor:auto

This was resolved here:

w3c/csswg-drafts#10312 (comment)

and will be added to the spec shortly.

This is observable, but barely. After this CL, `implicit` won't be a
valid value for `position-anchor`, so it'll resolve to the default
value of `auto`. Meaning the behavior will be the same. But via the
CSSOM, getComputedStyle(element).positionAnchor will now return "auto"
instead of "implicit".

Fixed: 340206288
Change-Id: I75b05310638dca70aa6aa8807da8cfe7c9624a32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540275
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301585}

--

wpt-commits: 6bdb665f70cda739fe30fad86cc89fef3b81e535
wpt-pr: 46269
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 23, 2024
@moz-wptsync-bot
Bug 1897009 [wpt PR 46293] - Remove auto value from anchor() function…
629d04e 
…, a=testonly

Automatic update from web-platform-tests
Remove auto value from anchor() function

See the CSSWG resolution here:

w3c/csswg-drafts#10312 (comment)

which says:

RESOLVED: Rename implicit to auto in position-anchor
RESOLVED: Drop the keyword from the anchor() function

The first part was taken care of in [1]. This CL takes care of
the second part.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5540275

Bug: 340206288
Change-Id: I33972e06104d061bb06232dac851877159b4fc92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5542337
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1302830}

--

wpt-commits: e9d9b035c90ea3e653816beebbe002ad6c18d608
wpt-pr: 46293
jamienicol pushed a commit to jamienicol/gecko that referenced this issue May 24, 2024
@moz-wptsync-bot
Bug 1896778 [wpt PR 46269] - Rename position-anchor:implicit to posit…
e1cce24 
…ion-anchor:auto, a=testonly

Automatic update from web-platform-tests
Rename position-anchor:implicit to position-anchor:auto

This was resolved here:

w3c/csswg-drafts#10312 (comment)

and will be added to the spec shortly.

This is observable, but barely. After this CL, `implicit` won't be a
valid value for `position-anchor`, so it'll resolve to the default
value of `auto`. Meaning the behavior will be the same. But via the
CSSOM, getComputedStyle(element).positionAnchor will now return "auto"
instead of "implicit".

Fixed: 340206288
Change-Id: I75b05310638dca70aa6aa8807da8cfe7c9624a32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540275
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301585}

--

wpt-commits: 6bdb665f70cda739fe30fad86cc89fef3b81e535
wpt-pr: 46269
jamienicol pushed a commit to jamienicol/gecko that referenced this issue May 24, 2024
@moz-wptsync-bot
Bug 1897009 [wpt PR 46293] - Remove auto value from anchor() function…
28bcfe0 
…, a=testonly

Automatic update from web-platform-tests
Remove auto value from anchor() function

See the CSSWG resolution here:

w3c/csswg-drafts#10312 (comment)

which says:

RESOLVED: Rename implicit to auto in position-anchor
RESOLVED: Drop the keyword from the anchor() function

The first part was taken care of in [1]. This CL takes care of
the second part.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5540275

Bug: 340206288
Change-Id: I33972e06104d061bb06232dac851877159b4fc92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5542337
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1302830}

--

wpt-commits: e9d9b035c90ea3e653816beebbe002ad6c18d608
wpt-pr: 46293
@tabatkins
Copy link
Member

Correct. The reduced version is already correct syntax with that meaning, it just will no longer be valid to write the implicit keyword explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted by CSSWG Resolution css-anchor-position-1 Needs Edits
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tabatkins @fantasai @astearns @yisibl @css-meeting-bot @mfreed7