Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cssom-1][css-page-3] What descriptor does CSSPageDescriptors.orientation represent? #10483

Closed
cdoublev opened this issue Jun 22, 2024 · 3 comments
Labels
css-page-3 Current Work cssom-1 Current Work

Comments

@cdoublev
Copy link
Collaborator

CSSPageDescriptors.orientation was added in #10482:

@page{ orientation: ... } Is generally treated the same as @page{ size: ... } [...]

In Chrome 126 and FF 127:

const sheet = new CSSStyleSheet()
sheet.replaceSync('@page { orientation: portrait }')
sheet.cssRules[0].cssText; // @page { }

Is it intented to be an attribute for page-orientation? (#10105) If so, is it intentional that its name is not pageOrientation?

@cdoublev cdoublev added css-page-3 Current Work cssom-1 Current Work labels Jun 22, 2024
@cdoublev cdoublev changed the title [cssom-1][css-page-3] What descriptor does CSSPageDescriptors.orientation represents? [cssom-1][css-page-3] What descriptor does CSSPageDescriptors.orientation represent? Jun 22, 2024
@emilio
Copy link
Collaborator

emilio commented Jun 22, 2024

Cc @AlaskanEmily

@AlaskanEmily
Copy link

Yes, I realized this just a little bit ago. I will open a new PR to fix that, it should be pageOrientation.

@emilio
Copy link
Collaborator

emilio commented Jul 2, 2024

Fixed by #10521

@emilio emilio closed this as completed Jul 2, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-page-3 Current Work cssom-1 Current Work
Projects
None yet
Development

No branches or pull requests

3 participants