Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-align] 'justify-self' should override 'auto' margins #1426

Closed
dbaron opened this issue May 20, 2017 · 3 comments
Closed

[css-align] 'justify-self' should override 'auto' margins #1426

dbaron opened this issue May 20, 2017 · 3 comments
Labels
Closed Rejected as Wontfix by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-align-3 Current Work

Comments

@dbaron
Copy link
Member

dbaron commented May 20, 2017

The current rules for applying justify-self to blocks and applying it to absolutely positioned elements are structured so that auto margins override justify-self(with the possible exception of baseline alignment when orthogonal).

However, I tend to think:

  • that the newer and more ergonomic API should override the older and less ergonomic API, and
  • that it wouldn't be too difficult to structure the rules so that non-normal values of justify-self override auto margins,

so I would suggest that we change so that justify-self wins.

This also moves towards erasing the quirk that auto margins do safe alignment for normal flow blocks and for the inline dimension on abspos, but unsafe alignment for the block dimension on abspos.

@dbaron dbaron added the css-align-3 Current Work label May 20, 2017
@dbaron
Copy link
Member Author

dbaron commented May 20, 2017

This also applies to the rules for align-self on absolutely positioned elements.

@fantasai
Copy link
Collaborator

Ok, so, while we fully sympathize with the desire to be rid of the terribleness in abspos margin alignment, the fact is that Grid and Flexbox already prioritize auto margins, and we feel it's definitely more important to remain consistent in this respect across all layout modes.

Let us know if you're satisfied with this resolution; otherwise please mark Agenda+ so we can discuss with the WG. :)

@dbaron
Copy link
Member Author

dbaron commented Jul 19, 2017

OK... I guess I should have caught that in flexbox.

@fantasai fantasai closed this as completed Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Rejected as Wontfix by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-align-3 Current Work
Projects
None yet
Development

No branches or pull requests

2 participants