Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text-decor] Link syntaxes with CSS Values #146

Closed
SebastianZ opened this issue May 27, 2016 · 5 comments
Closed

[css-text-decor] Link syntaxes with CSS Values #146

SebastianZ opened this issue May 27, 2016 · 5 comments

Comments

@SebastianZ
Copy link
Contributor

The combinators and multipliers within the syntaxes should link to the CSS Values module like other modules.

Sebastian

@astearns astearns added the css-text-decor-3 Current Work label Jun 1, 2016
@fantasai
Copy link
Collaborator

fantasai commented Jun 9, 2016

These will all be fixed the next time these specs are generated with Bikeshed. Please don't open more such issues. (Also if you have a generator issue, just file one across multiple specs, don't file one per spec.)

@tabatkins
Copy link
Member

That's not necessarily true; several of them are because some grammar definition is missing the class=prod that turns on CSS-grammar autolinking.

But yes, when you've got several specs with an identical issue, please just file one issue and add labels for all the specs. If you wanna be a superhero, put a checkbox-list of the specs that need attention, so we can track and mark progress easily.

@SebastianZ
Copy link
Contributor Author

Also if you have a generator issue, just file one across multiple specs, don't file one per spec.

But yes, when you've got several specs with an identical issue, please just file one issue and add labels for all the specs. If you wanna be a superhero, put a checkbox-list of the specs that need attention, so we can track and mark progress easily.

As the move to GitHub is still new, I didn't know how you'd like to have that issue filed, but fair enough, I'll keep that in mind next time. (I could also change one of the issues to hold a checkbox list and close the other ones, if you want to. Just let me know.)

Sebastian

@frivoal
Copy link
Collaborator

frivoal commented Jun 10, 2016

@tabatkins

That's not necessarily true; several of them are because some grammar definition is missing the class=prod that turns on CSS-grammar autolinking.

I fixed the CSS-UI spec not by adding class=prod, but by turning a <table class=propdef> into a <pre class=propdef>

@tabatkins
Copy link
Member

Yeah, that's because Bikeshed adds a class=prod to the when it generates the table for you. ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants