Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-shapes] Replace <shape-arg> with <length-percentage> #186

Closed
dholbert opened this issue Jun 14, 2016 · 2 comments
Closed

[css-shapes] Replace <shape-arg> with <length-percentage> #186

dholbert opened this issue Jun 14, 2016 · 2 comments
Assignees
@astearns @atanassov
Labels
css-shapes-1 Current Work

Comments

@dholbert
Copy link
Member

dholbert commented Jun 14, 2016 •
edited by tabatkins
Loading

(Upgrading bugzilla-tracked bug https://www.w3.org/Bugs/Public/show_bug.cgi?id=29598 to a github issue):

CSS Values and Units 3 now has ``, so the `` type could be dropped from CSS Shapes Module Level 1 and replaced with ``. That would reduce the indirection through the types and make them more directly visible.

There are also multiple occurrences of "<length> | <percentage>" and the inverse "<percentage> | <length>" that should be changed to <length-percentage>.

Links:

https://drafts.csswg.org/css-values-3/#typedef-length-percentage
https://drafts.csswg.org/css-shapes-1/#typedef-shape-arg
@dholbert
Copy link
Member Author

[CC @jwatt, @astearns, @vhardy, @atanassov)

@frivoal frivoal added the css-shapes-1 Current Work label Jun 15, 2016
@tabatkins
Copy link
Member

Fixed.

@tabatkins tabatkins removed the ready label Jun 28, 2016
birtles added a commit to birtles/csswg-drafts that referenced this issue Dec 4, 2017
@birtles
Make type of target argument to KeyframeEffect(ReadOnly) use a union …
a07f609 
…instead of a mix-in

It seems like in future mixins will no longer be interfaces in future
and will not be able to be used as an argument type.

Issue w3c#186.
birtles added a commit to birtles/csswg-drafts that referenced this issue Dec 4, 2017
@birtles
Also make the type of the target member of KeyframeEffect(ReadOnly)…
d0445d2 
… use a union instead of a mixin

See w3c#186.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astearns astearns

@atanassov atanassov

Labels
css-shapes-1 Current Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@frivoal @dholbert @tabatkins @astearns @atanassov