-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web-animations-1] Add parameter to getAnimations for getting animations in descendants too #2058
Comments
I discussed this with Antoine at one point and I think we were leaning against adding this. |
From @graouts on November 21, 2017 8:52 Yes, I don't think this is warranted, JavaScript can be efficiently used to filter results of getAnimations() calls. I suggest we close this. |
Yeah I agree about dropping the filter feature. I wonder if we might still want something along the lines of If we do go ahead with that then we might want something more extensible than a bool (although at the same time aligning with MutationObserver is nice). I'm not sure if we'll eventually need a third value for crossing shadow DOM boundaries or if that's even possible? |
Please don't cross shadow tree boundaries if that ends up exposing information about the shadow tree. |
@annevk Would it be ok to expose animations from a shadow tree if the shadow root is open? |
We don't generally draw a distinction there, I think. |
Yeah, the main difference with open is for |
Ok, I'm assuming that encapsulation applies even if the author were to explicitly pass a flag such as |
Yeah, they should not be able to access things inside the tree that way. It might be acceptable if they have a handle on the applicable |
From @birtles on March 17, 2016 0:48
As discussed and minuted here: The ideas we came up with are here: https://docs.google.com/document/d/1lQbgJ0fZYGn1_qboj59G-MOILK33z4kmBdjgtSHF2gA/edit#heading=h.cioj28lsgoa2
A more concrete elaboration on that proposal is described here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1254761#c0
Copied from original issue: w3c/web-animations#146
The text was updated successfully, but these errors were encountered: