Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-align][css-multicol] Make "column-gap: normal" to be 1em in multi-column per spec #2145

Closed
mrego opened this issue Dec 29, 2017 · 8 comments

Comments

@mrego
Copy link
Member

mrego commented Dec 29, 2017

Specs:

There's an issue in css-align about this:

ISSUE 4: Should normal just compute to 1em in multicol?

I've realized there's a WPT test checking exactly that: http://w3c-test.org/css/css-multicol/multicol-gap-001.xht
Right now is marked as optional, but it passes in all the browsers I checked: Chromium, Safari, Firefox and Edge.

Maybe it's possible to update the specs and make this test mandatory. WDYT?

@mrego mrego added css-align-3 Current Work css-multicol-1 Current Work labels Dec 29, 2017
@rachelandrew
Copy link
Contributor

Do we know what non-web browser UAs are doing here? I imagine they may be using something different.

@frivoal
Copy link
Collaborator

frivoal commented Jan 3, 2018

At least Vivliostyle, Prince, and Pdfreactor use 1em as well. I do not have an Antenna House install to test, but i'd be surprised if it differed.

@frivoal frivoal added this to Needs discussion in css-multicol-1 Mar 29, 2018
@frivoal
Copy link
Collaborator

frivoal commented Mar 29, 2018

@MurakamiShinyu Do you know what the behavior of AH formatter is for this? Is column-gap normal 1em, or some other value?

@MurakamiShinyu
Copy link
Collaborator

AH formatter uses 1em as well.

@frivoal
Copy link
Collaborator

frivoal commented Mar 30, 2018

In that case, I think we should just resolve that it's 1em, and remove the "UA defined" bit, as that doesn't seem to help anyone.

@rachelandrew
Copy link
Contributor

I agree, it seems that there is interop on this, so there seems no sense in leaving room for ambiguity.

@css-meeting-bot
Copy link
Member

The Working Group just discussed Make "column-gap: normal" to be 1em in multi-column per spec, and agreed to the following resolutions:

  • RESOLVED: remove the UI defined bit and go with 1em for computing normal in multi-col
The full IRC log of that discussion <dael> Topic: Make "column-gap: normal" to be 1em in multi-column per spec
<dael> AmeliaBR: In the multi-col spec there's a suggested value of 1em
<dael> AmeliaBR: Everyone is doing 1em so we suggest it's mandatory.
<AmeliaBR> s/AmeliaBR/rachelandrew /
<dael> florian: And this interop includes print. Let's go for it.
<dael> github: https://github.com//issues/2145#issuecomment-377445142
<fantasai> s/AmeliaBR/rachelandrew/
<dael> astearns: proposed is remove the UI defined bit and go with 1em for computing normal in multi-col
<dael> RESOLVED: remove the UI defined bit and go with 1em for computing normal in multi-col

@rachelandrew
Copy link
Contributor

failed to reference the issue, but commit is here for multicol bf38268

@fantasai fantasai closed this as completed Apr 5, 2018
mrego added a commit to mrego/wpt that referenced this issue Apr 5, 2018
The CSSWG resolved to make it explicit in the spec in issue w3c/csswg-drafts#2145.
The reason is that there's interop between all UAs regarding this.

These 2 tests were marked as optional "may" but they're not optional anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

6 participants