[css-grid] Applying 'align-content' content distribution to row estimation in step 1 in Grid Sizing algo #2697
Milestone
Comments
Sounds good to me. Agenda+ for objections. :) |
The Working Group just discussed
The full IRC log of that discussion<dael> Topic: end<dael> github: https://github.com//issues/2697 <dael> fantasai: I think this is a matter of getting it correct <dael> astearns: Additional comments? <dael> astearns: Objections to accepting https://github.com//issues/2697 or do people need time? <dael> RESOLVED: Accept proposal in https://github.com//issues/2697 |
Fix checked in. Let me know if there are any errors! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow-up from #2557.
The row size estimation for step 1 mentions "if any row with a definite max track sizing function had that size and all other rows were infinite". I tend to think this implies that if all rows have a definite max track sizing function, and the container has a definite block-size, that
align-content
should be applied. @javifernandez' example in #2557:should render exactly the same as if we add
grid-row-gap:100px
:So I propose we add
align-content
content distribution for this specific case (all rows have definite max size) to the row estimation heuristics for step 1.The text was updated successfully, but these errors were encountered: