Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-box-3] Should we move the border property defs from css-backgrounds-3 to css-box-3? #3007

Closed
fantasai opened this issue Aug 9, 2018 · 5 comments

Comments

@fantasai
Copy link
Collaborator

fantasai commented Aug 9, 2018

Now that we've trimmed down the box module, deferring box generation to css-display and block layout to a forthcoming css-block module, should we move the border properties from css-backgrounds-3 to css-box-3?

Pros: Makes more sense?
Cons: They've been in css-backgrounds-3 for more than a decade.

Discuss!

@astearns
Copy link
Member

astearns commented Aug 9, 2018

What about a note in css-box-3 mentioning that you might expect the properties there, but for historical reasons they're over in backgrounds?

@SelenIT
Copy link
Collaborator

SelenIT commented Aug 15, 2018

IMHO, borders belong where they currently are more than just for historical reasons. The only aspect of borders that effectively participates in the box model construction seems to be the size of the border area, that is, border-width. Other border aspects (border-color and border-style, let alone border-image) are about rendering borders, not about box geometry. I believe it makes sense to keep those aspects together with other rules of painting different areas of the element (like background-clip/-origin, which also refer to box model parts). A note and a cross-reference would be a great solution for me.

@fantasai
Copy link
Collaborator Author

OK. There was a cross-reference from the intro, but I added a dedicated section for it. @astearns @SelenIT Let me know if this looks good to you! https://drafts.csswg.org/css-box-3/#borders

@astearns
Copy link
Member

Looks fine to me. I’d probably use “describe” or “indicate” rather than “delineate,” but I‘ll leave that up to you.

@SelenIT
Copy link
Collaborator

SelenIT commented Nov 27, 2018

Looks great! Only the comma between "...the edges of the box" and "The border properties..." looks like a minor typo (shouldn't it be a full stop)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants