-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-text-decor-3] suggestion to support obituary line style #3438
Comments
I think it is pretty safe to close this issue as nothing needs to be changed. Firstly, decoration lines on the right side in vertical writing mode in Japanese is considered to be underline, not overline, and thus this case is already well covered by |
The spec seems correct, but the illustrations have the line a bit too close. Updated the images @macnmm Let me know if they look OK? Old: https://www.w3.org/TR/2018/CR-css-text-decor-3-20180703/#underline-left |
@fantasai For normal underline/overline, the former graphic was ok in terms of its placement. For "accounting underline" or "obituary line", your new graphic is more correct in terms of being slightly farther from the text, but usually in Japanese the line is made thicker as well. |
Ok, reverted. Seems like there's nothing to do here, then? |
We have |
We also need to define these positions a little more precisely in L4. :) |
In Japanese newspaper decoration, there is a form of overline (right side in vertical) used in obituaries, similar to the "accounting underline" shown in https://www.w3.org/TR/css-text-decor-3/images/underline-position-under.png
https://assets.shaso.jp/wp-content/uploads/2016/01/16040358/142cd3d08e8332a0f30b5c0bc2560a31.jpg
Its placement is different from normal overline (set more outside the line, not touching the embox) and is thicker than overline. Perhaps inclusion of an example like this could be useful?
The text was updated successfully, but these errors were encountered: