Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text-decor-3] suggestion to support obituary line style #3438

Closed
macnmm opened this issue Dec 12, 2018 · 6 comments
Closed

[css-text-decor-3] suggestion to support obituary line style #3438

macnmm opened this issue Dec 12, 2018 · 6 comments

Comments

@macnmm
Copy link

macnmm commented Dec 12, 2018

In Japanese newspaper decoration, there is a form of overline (right side in vertical) used in obituaries, similar to the "accounting underline" shown in https://www.w3.org/TR/css-text-decor-3/images/underline-position-under.png

https://assets.shaso.jp/wp-content/uploads/2016/01/16040358/142cd3d08e8332a0f30b5c0bc2560a31.jpg

Its placement is different from normal overline (set more outside the line, not touching the embox) and is thicker than overline. Perhaps inclusion of an example like this could be useful?

@upsuper upsuper added the css-text-decor-3 Current Work label Dec 13, 2018
@upsuper
Copy link
Member

upsuper commented Dec 13, 2018

I think it is pretty safe to close this issue as nothing needs to be changed.

Firstly, decoration lines on the right side in vertical writing mode in Japanese is considered to be underline, not overline, and thus this case is already well covered by text-underline-position: under right.

@fantasai
Copy link
Collaborator

The spec seems correct, but the illustrations have the line a bit too close. Updated the images @macnmm Let me know if they look OK?

Old: https://www.w3.org/TR/2018/CR-css-text-decor-3-20180703/#underline-left
New: https://drafts.csswg.org/css-text-decor-3/#underline-left

@macnmm
Copy link
Author

macnmm commented May 24, 2019

@fantasai For normal underline/overline, the former graphic was ok in terms of its placement. For "accounting underline" or "obituary line", your new graphic is more correct in terms of being slightly farther from the text, but usually in Japanese the line is made thicker as well.
Since the graphic seems to be intended to depict normal underline, the original graphic is actually closer. It is hard to tell as the embox boundaries are not clear (I will email you a picture to show what I am talking about).

fantasai added a commit that referenced this issue May 25, 2019
@fantasai
Copy link
Collaborator

Ok, reverted. Seems like there's nothing to do here, then?

@fantasai
Copy link
Collaborator

We have text-underline-offset and text-underline-thickness in L4 for customizing the underline position/thickness.

@fantasai
Copy link
Collaborator

We also need to define these positions a little more precisely in L4. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants