Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid] The value of the fixed track sizing function doesn't seem to matter when resolving intrinsic track sizes #3706

Closed
Loirooriol opened this issue Mar 4, 2019 · 2 comments

Comments

@Loirooriol
Copy link
Contributor

From https://drafts.csswg.org/css-grid/#algo-spanning-flex-items,

Increase sizes to accommodate spanning items crossing flexible tracks: Next, repeat the previous step instead considering (together, rather than grouped by span size) all items that do span a track with a flexible sizing function while [...] distributing space only to flexible tracks (i.e. treating all other tracks as having a fixed sizing function of their current base size)

If I'm not missing anything, the "Resolve Intrinsic Track Sizes" algorithm doesn't use the value of the track sizing function in case it's fixed. So it doesn't seem to matter whether it's treated as the current base size, 0, 100px, or any other fixed value. I think the sentence could be shortened to

distributing space only to flexible tracks (i.e. treating all other tracks as having a fixed sizing function)

@fantasai
Copy link
Collaborator

fantasai commented Mar 5, 2019

That wouldn't explain what value to use as the fixed sizing function. The current wording says to use the current base size, which defines what to do with track sizes specified as intrinsic sizing functions. Fixed tracks will have their base sizes set to that size already in https://drafts.csswg.org/css-grid-1/#algo-init LMK if you meant something else...

@Loirooriol
Copy link
Contributor Author

Loirooriol commented Mar 5, 2019

Exactly, https://drafts.csswg.org/css-grid-1/#algo-init uses the value of fixed track sizing functions in order to set initial base sizes and growth limits. But https://drafts.csswg.org/css-grid-1/#algo-content doesn't seem to care about the value of fixed track sizing functions, it references the derived base sizes and growth limits instead.

So what I'm saying is that https://drafts.csswg.org/css-grid/#algo-spanning-flex-items is overriding the track sizing function of some tracks, but not their base sizes nor growth limits. It's these base sizes and growth limits what will be used when doing the "repeat the previous step". The specific value of the overriding track sizing function won't be used anywhere, so it doesn't matter.

Since it doesn't matter it's fine if you want to leave it as "their current base size", I was just suggesting that the sentence can be simplified.

@Loirooriol Loirooriol changed the title [css-grid] The value of the fixed track sizing function doesn't seem to matter [css-grid] The value of the fixed track sizing function doesn't seem to matter when resolving intrinsic track sizes Mar 5, 2019
@fantasai fantasai closed this as completed Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants