-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-color-adjust-1] Forced Colors Mode issues #3860
Comments
Let's not use the term "nits". That refers to screen brightness. |
Or perhaps use shorthand |
??? |
My reaction, too. But per Wikipedia “Nit (nt) is a non-SI name also used for [a candela per square metre] (1 nt = 1 cd/m2). The term nit is believed to come from the Latin word nitere, to shine.” I would not normally consider that specialized usage a conflict with the colloquial meaning of "nit" as "minor bug, like a louse", as in "nit-picking". But if if confused a native English speaker like Simon, it could certainly confuse non-native speakers who work with computer graphics but not with English idioms. So, no harm changing it. All of which isn't relevant to @BillGoldstein's original suggestions, which makes good points, but is a bit of a mixture of items that need to be addressed separately. @tabatkins, can you follow up on the typos? For the |
Fixed the typos, pushed the -webkit-text issue out to w3c/fxtf-drafts#400 |
In section
3.1. Properties Affected by Forced Colors Mode
https://drafts.csswg.org/css-color-adjust-1/#forced-colors-properties
-scrollbar-colors: revert !important;
+scrollbar-color: revert !important;
as it got renamed.
-outline-color: revert !important
+outline-color: revert !important;
missing semicolon
Consider these, too:
+-webkit-text-fill-color: revert !important;
+-webkit-text-stroke-color: revert !important;
as they're in the compatibility spec https://compat.spec.whatwg.org/#text-fill-and-stroking
though they may well be implemented as aliases.
The text was updated successfully, but these errors were encountered: