Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-color-adjust-1] Forced Colors Mode issues #3860

Closed
BillGoldstein opened this issue Apr 20, 2019 · 5 comments
Closed

[css-color-adjust-1] Forced Colors Mode issues #3860

BillGoldstein opened this issue Apr 20, 2019 · 5 comments

Comments

@BillGoldstein
Copy link

In section
3.1. Properties Affected by Forced Colors Mode
https://drafts.csswg.org/css-color-adjust-1/#forced-colors-properties

-scrollbar-colors: revert !important;
+scrollbar-color: revert !important;
as it got renamed.

-outline-color: revert !important
+outline-color: revert !important;
missing semicolon

Consider these, too:
+-webkit-text-fill-color: revert !important;
+-webkit-text-stroke-color: revert !important;
as they're in the compatibility spec https://compat.spec.whatwg.org/#text-fill-and-stroking
though they may well be implemented as aliases.

@AmeliaBR AmeliaBR added the css-color-adjust-1 Current Work label Apr 20, 2019
@smfr
Copy link
Contributor

smfr commented Apr 22, 2019

Let's not use the term "nits". That refers to screen brightness.

@smfr smfr changed the title [css-color-adjust-1] Forced Colors Mode nits [css-color-adjust-1] Forced Colors Mode issues Apr 22, 2019
@BillGoldstein
Copy link
Author

Or perhaps use shorthand
+-webkit-text-stroke: revert !important;
(which is also in compat standard), instead of longhand
+-webkit-text-stroke-color: revert !important;

@tabatkins
Copy link
Member

Let's not use the term "nits". That refers to screen brightness.

???

@tabatkins tabatkins added this to Needs triage in Blink Issue Triage via automation Apr 26, 2019
@tabatkins tabatkins moved this from Needs triage to No Action Needed in Blink Issue Triage Apr 26, 2019
@AmeliaBR
Copy link
Contributor

AmeliaBR commented Apr 27, 2019

???

My reaction, too. But per Wikipedia “Nit (nt) is a non-SI name also used for [a candela per square metre] (1 nt = 1 cd/m2). The term nit is believed to come from the Latin word nitere, to shine.”

I would not normally consider that specialized usage a conflict with the colloquial meaning of "nit" as "minor bug, like a louse", as in "nit-picking". But if if confused a native English speaker like Simon, it could certainly confuse non-native speakers who work with computer graphics but not with English idioms. So, no harm changing it.


All of which isn't relevant to @BillGoldstein's original suggestions, which makes good points, but is a bit of a mixture of items that need to be addressed separately.

@tabatkins, can you follow up on the typos?

For the -webkit- fill and stroke properties, we should probably discuss them in combination with the standard fill and stroke, maybe as part of #3855, about handling SVG. There, I suggested using a fill: currentColor for SVG, but a revert could also work in that case.

@fantasai
Copy link
Collaborator

Fixed the typos, pushed the -webkit-text issue out to w3c/fxtf-drafts#400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Blink Issue Triage
  
No Action Needed
Development

No branches or pull requests

5 participants