[css-fonts] Inconsistency between monospace and ui-monospaced
#4469
Labels
Comments
|
Let’s fix that before any browser ships this. We don’t want yet another item to add to the ever expanding list of legacy CSSWG mistakes. |
|
Whoops!! Yes, let’s fix this immediately |
|
I think I should be able to just make the edit, since this is so new and has no implementations. I'm not sure it's worth bringing up on the call. |
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this issue
Dec 22, 2020
…ont family https://bugs.webkit.org/show_bug.cgi?id=203602 Reviewed by Simon Fraser. Source/WebCore: As per w3c/csswg-drafts#4469 Updated existing tests. * platform/graphics/cocoa/FontCacheCoreText.cpp: (WebCore::platformFontLookupWithFamily): (WebCore::fontWithFamilySpecialCase): * platform/graphics/cocoa/FontDescriptionCocoa.cpp: (WebCore::matchSystemFontUse): * platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp: (WebCore::SystemFontDatabaseCoreText::createDesignSystemUIFont): (WebCore::SystemFontDatabaseCoreText::cascadeList): (WebCore::SystemFontDatabaseCoreText::systemFontParameters): * platform/graphics/cocoa/SystemFontDatabaseCoreText.h: LayoutTests: Updated existing tests. * fast/text/design-system-ui-12.html: * fast/text/design-system-ui-15.html: * fast/text/design-system-ui-2-expected.html: * fast/text/design-system-ui-2.html: * fast/text/design-system-ui-4-expected-mismatch.html: * fast/text/design-system-ui-4.html: * fast/text/design-system-ui-7-expected.html: * fast/text/design-system-ui-7.html: * fast/text/design-system-ui-9-expected-mismatch.html: * fast/text/design-system-ui-9.html: Canonical link: https://commits.webkit.org/217192@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The new UI font keywords recently added to Fonts 4 includes
ui-monospaced(note the "d" at the end). In contrast, the existing generic keyword ismonospace(no "d").There is already lots of potential for authoring confusion over whether to include the "d" at the end of
monospaceor not, because both terms are used interchangeably in typography (monospace font or monospaced font). I don't think it is helpful to have two keywords in CSS with different grammatical inflections, it will make it that much harder to remember which version is correct.The text was updated successfully, but these errors were encountered: