Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-fonts] Inconsistency between `monospace` and `ui-monospaced` #4469

Closed
AmeliaBR opened this issue Oct 29, 2019 · 3 comments
Labels

Comments

@AmeliaBR
Copy link
Contributor

@AmeliaBR AmeliaBR commented Oct 29, 2019

The new UI font keywords recently added to Fonts 4 includes ui-monospaced (note the "d" at the end). In contrast, the existing generic keyword is monospace (no "d").

There is already lots of potential for authoring confusion over whether to include the "d" at the end of monospace or not, because both terms are used interchangeably in typography (monospace font or monospaced font). I don't think it is helpful to have two keywords in CSS with different grammatical inflections, it will make it that much harder to remember which version is correct.

@ExE-Boss

This comment has been minimized.

Copy link
Contributor

@ExE-Boss ExE-Boss commented Oct 29, 2019

Let’s fix that before any browser ships this.

We don’t want yet another item to add to the ever expanding list of legacy CSSWG mistakes.

@fantasai fantasai added the Agenda+ label Oct 29, 2019
@litherum

This comment has been minimized.

Copy link
Contributor

@litherum litherum commented Oct 30, 2019

Whoops!! Yes, let’s fix this immediately

@litherum

This comment has been minimized.

Copy link
Contributor

@litherum litherum commented Oct 30, 2019

I think I should be able to just make the edit, since this is so new and has no implementations. I'm not sure it's worth bringing up on the call.

@litherum litherum closed this in 385d0bb Oct 30, 2019
@litherum litherum removed the Agenda+ label Oct 30, 2019
pmatos pushed a commit to pmatos/WebKit that referenced this issue Nov 5, 2019
…ont family

https://bugs.webkit.org/show_bug.cgi?id=203602

Reviewed by Simon Fraser.

Source/WebCore:

As per w3c/csswg-drafts#4469

Updated existing tests.

* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::platformFontLookupWithFamily):
(WebCore::fontWithFamilySpecialCase):
* platform/graphics/cocoa/FontDescriptionCocoa.cpp:
(WebCore::matchSystemFontUse):
* platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:
(WebCore::SystemFontDatabaseCoreText::createDesignSystemUIFont):
(WebCore::SystemFontDatabaseCoreText::cascadeList):
(WebCore::SystemFontDatabaseCoreText::systemFontParameters):
* platform/graphics/cocoa/SystemFontDatabaseCoreText.h:

LayoutTests:

Updated existing tests.

* fast/text/design-system-ui-12.html:
* fast/text/design-system-ui-15.html:
* fast/text/design-system-ui-2-expected.html:
* fast/text/design-system-ui-2.html:
* fast/text/design-system-ui-4-expected-mismatch.html:
* fast/text/design-system-ui-4.html:
* fast/text/design-system-ui-7-expected.html:
* fast/text/design-system-ui-7.html:
* fast/text/design-system-ui-9-expected-mismatch.html:
* fast/text/design-system-ui-9.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@252034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.