Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mediaqueries] The <general-enclosed> production contains unbalanced parentheses #4534

Closed
papandreou opened this issue Nov 24, 2019 · 3 comments
Labels

Comments

@papandreou
Copy link
Contributor

In https://www.w3.org/TR/mediaqueries-4/#mq-syntax the <general-enclosed> production contains an unmatched end parenthesis:

<general-enclosed> = [ <function-token> <any-value> ) ] | ( <ident> <any-value> )

I think it should have been:

<general-enclosed> = [ <function-token> ( <any-value> ) ] | ( <ident> <any-value> )
@Loirooriol
Copy link
Contributor

The opening parenthesis is included in <function-token>.
See https://drafts.csswg.org/css-syntax-3/#ref-for-typedef-function-token%E2%91%A0,

<function-token> = <ident-token> (

@dbaron
Copy link
Member

dbaron commented Nov 24, 2019

Correct, the <function-token> contains the parenthesis.

@dbaron dbaron closed this as completed Nov 24, 2019
@papandreou
Copy link
Contributor Author

Ah, thanks -- sorry for the noise! I'm working on a CSS fuzzer and had implemented <function-token> wrong, so ended up with the unbalanced parentheses 🤪

papandreou added a commit to papandreou/css-generators that referenced this issue Nov 24, 2019
@frivoal frivoal added the Testing Unnecessary Memory aid - issue doesn't require tests label Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants