Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid] Definition of fit-content() uses min()/max() wrong #4789

Closed
tabatkins opened this issue Feb 18, 2020 · 0 comments
Closed

[css-grid] Definition of fit-content() uses min()/max() wrong #4789

tabatkins opened this issue Feb 18, 2020 · 0 comments
Labels
Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-grid-1

Comments

@tabatkins
Copy link
Member

In https://drafts.csswg.org/css-grid/#valdef-grid-template-columns-fit-content, the formula is stated as:

min(minimum, max(limit, max-content))

This is not how you clamp a value between a min and max; instead, it ensures that the result is outside of the min-max range. Need to swap the use of min() and max() there, or switch to a clamp() notation now that that's well-defined.

@tabatkins tabatkins added Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. labels Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-grid-1
Projects
None yet
Development

No branches or pull requests

1 participant