Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flexbox] Collecting items into lines: use hypothetical main sizes? #4906

Closed
SimonSapin opened this issue Mar 27, 2020 · 2 comments
Closed
Labels
Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-flexbox-1 Current Work

Comments

@SimonSapin
Copy link
Contributor

https://drafts.csswg.org/css-flexbox/#algo-line-break

collect consecutive items one by one until the first time that the next collected item would not fit into the flex container’s inner main size

What does it mean for items to “fit”? Given that this step comes soon after computing a hypothetical main size for each flex item it would make sense to rely on those (plus main axis padding and borders and margins, with zero for auto margins), but that is not defined.

@SimonSapin SimonSapin added the css-flexbox-1 Current Work label Mar 27, 2020
@Loirooriol
Copy link
Contributor

Isn't it already defined in the next paragraph?

For this step, the size of a flex item is its outer hypothetical main size.

@SimonSapin
Copy link
Contributor Author

Hmm it looks like I just missed this when reading that section. Sorry!

@SimonSapin SimonSapin added Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. and removed Commenter Response Pending labels Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-flexbox-1 Current Work
Projects
None yet
Development

No branches or pull requests

3 participants