Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-sizing-4] [mediaqueries-4] [css-values-4] Definition of <ratio> should probably be in css-values #4908

Closed
cbiesinger opened this issue Mar 27, 2020 · 1 comment
Closed

[css-sizing-4] [mediaqueries-4] [css-values-4] Definition of <ratio> should probably be in css-values #4908

cbiesinger opened this issue Mar 27, 2020 · 1 comment
Labels
Closed Accepted by Editor Discretion css-sizing-4 css-values-4 Current Work mediaqueries-4 Current Work Testing Unnecessary Memory aid - issue doesn't require tests Tracked in DoC

Comments

@cbiesinger
Copy link

Both css-sizing-4 and mediaqueries-4 use a type:
https://drafts.csswg.org/css-sizing-4/#aspect-ratio
https://drafts.csswg.org/mediaqueries-4/#typedef-ratio

The former links to the latter for its definition, but it seems it would be better if it were defined in the "CSS Values and Units" spec instead.
@tabatkins
Copy link
Member

Yeah, we considered this previously, but left <ratio> alone in MQ because it was still the only consumer, and we generally want to keep V&U only for cross-language types.

But now that <ratio> is used across multiple specs, yeah, it probably should migrate to V&U.

@tabatkins tabatkins mentioned this issue Apr 15, 2020
Closed
JTensai pushed a commit to JTensai/csswg-drafts that referenced this issue May 13, 2020
@tabatkins
[css-values-4][mediaqueries-4] Move the definition of <ratio> to V&U …
fa62ded 
…now that it's used in more than one spec. Closes w3c#4908.
@frivoal frivoal added the Testing Unnecessary Memory aid - issue doesn't require tests label Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted by Editor Discretion css-sizing-4 css-values-4 Current Work mediaqueries-4 Current Work Testing Unnecessary Memory aid - issue doesn't require tests Tracked in DoC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@frivoal @tabatkins @fantasai @cbiesinger