-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-color-adjust-1] Why special-casing background-image for inputs? #4917
Comments
@emilio I believe this was a remnant of Legacy Microsoft Edge behavior. I agree that this shouldn't be necessary, especially with the backplate feature, and I would support removing this from the spec. |
We inherited this from Microsoft's definition, so that's a question for @atanassov and @melanierichards :)
It's ill-defined because appropriate behavior can vary by platform. CSS/HTML doesn't define what controls "look like" buttons, but that's intended the criteria here... |
We actually don't need this behavior given that the backplate is now covering all of these scenarios. I recommend removing the text from the spec and closing this issue. |
The CSS Working Group just discussed
The full IRC log of that discussion<heycam> Topic: Why special-casing background-image for inputs?<heycam> github: https://github.com//issues/4917 <heycam> Rossen_: this issue is calling out some special casing that was added for bg images on input elements <heycam> ... for the purposes of forced colors <heycam> ... and this was a legacy behavior that was carried forward over the years and not really necessary any more <heycam> ... since we have the backplate, which is used to guarantee contrast where needed <heycam> ... just commented earlier on the issue earlier, I'm completely fine with removing it from the spec and closing the issue <heycam> ... unless anyone has any reason why we shouldn't <heycam> ... any objections to removing the special casing and closing the issue? <heycam> RESOLVED: Remove the special case of background images on input elements wrt forced colors <TabAtkins> i'm fine with moving to inline issues <fantasai> https://github.com//issues/3199#issuecomment-634368358 |
Resolved by the WG and PR landed. Closing. |
https://drafts.csswg.org/css-color-adjust-1/#forced-colors-properties has a somewhat odd condition:
Two questions:
Why special-casing input / textareas? I've never seen a textarea styled with
background-image
so I'm actually surprised that this special-casing is necessary.If it is necessary, that sentence seems a bit ill-defined. Is
<input type=color>
a button-like control? What about<select>
?cc @atanassov
The text was updated successfully, but these errors were encountered: