Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-ruby] effect of line-height on nested ruby containers #4986

Closed
frivoal opened this issue Apr 22, 2020 · 2 comments
Closed

[css-ruby] effect of line-height on nested ruby containers #4986

frivoal opened this issue Apr 22, 2020 · 2 comments
Labels
Closed Accepted by CSSWG Resolution Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-ruby-1 Current Work Needs Testcase (WPT)

Comments

@frivoal
Copy link
Collaborator

frivoal commented Apr 22, 2020

A follow up question to #4979:

What is the effect of line-height on a nested ruby container. As far as the effect on its insides, there should be no difference compared to a non-nested ruby container, and that should do nothing (assuming we resolve that way in 4979). What about its effects towards the outside. I can see two possibilities:

  • There is no effect
  • it does nothing to the outer ruby, but it does affect the line that it is in, in the same way any (possibly nested) inline box would.
@upsuper
Copy link
Member

upsuper commented Apr 29, 2020

There are two cases of nested ruby container: it can be nested within the ruby base, or in ruby annotation. I suppose you are talking about the former.

My understanding is that for ruby container inside another ruby base, such ruby container behaves just like a normal inline element that contributes its line height to the line. When it's nested inside ruby annotation, on the other hand, line height would have no effect, because ruby annotation container doesn't care about line height.

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed effect of line-height on nestd ruby containers, and agreed to the following:

  • RESOLVED: nested ruby containers behave as inline boxes for the purpose of line-height
The full IRC log of that discussion <astearns> topic: effect of line-height on nestd ruby containers
<astearns> github: https://github.com//issues/4986
<emilio> florian: if we'd have resolved that line-height does something on the inner boxes then this would be more interesting
<emilio> florian: but given we resolved it doesn't we should probably say that this behaves like setting line-height on nested inline boxes
<emilio> astearns: xidorn, you mentioned that there's two different kinds of nesting?
<emilio> florian: a ruby container nested in a ruby base should affect the line it's in, but one nested inside an annotation it should do nothing
<emilio> fantasai: hmm, not sure about nothing
<emilio> fantasai: should probably be whatever inlines do in that case
<emilio> florian: we can agree on it being not magic
<emilio> RESOLVED: nested ruby containers behave as inline boxes for the purpose of line-height

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted by CSSWG Resolution Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-ruby-1 Current Work Needs Testcase (WPT)
Projects
None yet
Development

No branches or pull requests

4 participants