Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-ruby] [editorial] Reconsider the use of the term "formatting context" #5047

Closed
litherum opened this issue May 6, 2020 · 4 comments
Closed
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-display-3 Current Work css-ruby-1 Current Work editorial Testing Unnecessary Memory aid - issue doesn't require tests

Comments

@litherum
Copy link
Contributor

litherum commented May 6, 2020

During the F2F this month, we're discussing many issues about ruby layout. In particular, we're resolving that line-height applies the same way it does for nested <span>s. It's already true that ruby participates in line justification within its containing line.

The term "formatting context" indicates a large amount of independence, but ruby seems to act more like <span>s than it does floats or inline-blocks. Our layout team has been led astray by this term being used in the spec. It's probably worth reconsidering whether or not this term is invoked.

(For comparison, the definition of text-emphasis doesn't use this term.)

@litherum litherum added the css-ruby-1 Current Work label May 6, 2020
@frivoal
Copy link
Collaborator

frivoal commented May 9, 2020

I think based on the terminology established by css-display-3, this is indeed a "formatting context", but it is not an "independent formatting context".

So the terminology is being used correctly, but that doesn't mean it's not misleading.

@frivoal frivoal added the css-display-3 Current Work label May 9, 2020
@frivoal
Copy link
Collaborator

frivoal commented May 9, 2020

An easy way out would be simply to add a note in css-ruby, right next to where we say ruby containers establish a formatting context:

However ruby containers also establish a ruby formatting context that builds further structure around their segment of the inline formatting context. Note: this is not an independent formatting context

@tabatkins
Copy link
Member

Yeah, the terminology is well-defined; I could see us coming up with a different name, but I'm less sure that we can come up with a related term for "independent formatting context" that doesn't cause the same confusion.

frivoal added a commit that referenced this issue Jan 29, 2021
This reduces apparent ambiguities that were actually well defined,
but through non obvious terminology.

See #5047
@frivoal
Copy link
Collaborator

frivoal commented Jan 29, 2021

@litherum , after 76b1897, this ought to be clearer now. Can you have a look over at https://drafts.csswg.org/css-ruby-1/#formatting-context (giving bikeshed enough time to rebuild) and confirm this is now ok to close?

@frivoal frivoal added Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. and removed Commenter Response Pending labels Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-display-3 Current Work css-ruby-1 Current Work editorial Testing Unnecessary Memory aid - issue doesn't require tests
Projects
None yet
Development

No branches or pull requests

3 participants