Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-color-adjust] Should dark mode apply to favicons? #5205

Closed
chrishtr opened this issue Jun 12, 2020 · 5 comments
Closed

[css-color-adjust] Should dark mode apply to favicons? #5205

chrishtr opened this issue Jun 12, 2020 · 5 comments

Comments

@chrishtr
Copy link
Contributor

I think it should. This doesn't seem to be in the spec, just make a simple addition?

See also this Chromium issue.

@fantasai
Copy link
Collaborator

Can you clarify what you mean by "apply"?

@chrishtr
Copy link
Contributor Author

i.e. Should a dark mode theme apply to the document containing the SVG favicon, thereby adjusting its default background and foreground colors, etc?

@fantasai
Copy link
Collaborator

@chrishtr It should be handled no differently from any other linked/embedded SVG document. If it's an external document, it won't inherit any CSS properties, because those don't inherit through such links. But it should be given the same @media environment, and should follow the same rules as the loading of any other SVG document. We don't make any exceptions for favicons, so I don't see why that wouldn't be the case already.

Is there something you think should be happening that's an exception to the normal way we handle SVG documents?

@chrishtr
Copy link
Contributor Author

Ok, this makes sense. The spec for them in HTML also says it has the same @media environment: https://html.spec.whatwg.org/#rel-icon

Is there something you think should be happening that's an exception to the normal way we handle SVG documents?

No, I just wanted to make sure favicons would get the same color scheme and that this is in the spec.

@lilles
Copy link
Member

lilles commented Jun 19, 2020

The Chromium bug in this description is for devtools emulation, not favicons in the "normal" case.

There was an issue with SVG favicons not being rendered with the correct prefers-color-scheme, but that has been fixed: https://crbug.com/1090464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants