Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scroll-animations-1] Handling of unspecified value for source seems incorrect #5211

Closed
majido opened this issue Jun 14, 2020 · 2 comments
Closed

[scroll-animations-1] Handling of unspecified value for source seems incorrect #5211

majido opened this issue Jun 14, 2020 · 2 comments
Assignees
@majido
Labels
scroll-animations-1 Current Work
Milestone
scroll-animations...

Comments

@majido
Copy link
Contributor

majido commented Jun 14, 2020

Here is the wording for source descriptor:

otherwise if not specified or none then it is the the scrollingElement of the Document associated with the Window that is the current global object.

Note that 'source' is defaulted to 'none' which is interpreted as document root scroller. This seems like a bad choice to have none mean something. We should probably use 'auto' for this purpose and reserve 'none' for situation where source is null.
@majido majido self-assigned this Jun 14, 2020
@majido majido added the scroll-animations-1 Current Work label Jun 14, 2020
@andruud
Copy link
Member

andruud commented Jun 17, 2020

I agree, auto is better.

@majido majido mentioned this issue Jun 25, 2020
Merged
majido added a commit that referenced this issue Jun 26, 2020
@majido
[scroll-animations] let source be explicitly nullable (#5202, #5211) (#…
c705130 
…5263)

Fixing #5202 and #5211

Changes:
- Fix IDL to make source nullable.
- In CSS source will accept 'auto' and 'none' with none mapping to null.
- In JS, we now map missing 'source' to document scrolling element (i.e., auto behavior) and explicitly null 'source' to null.
- Correctly check null source when calculating offsets.

Other minor cleanups.
@majido
Copy link
Contributor Author

majido commented Jun 30, 2020

Spec is fixed. I have filed a bug to fix Chromium implementation.

@majido majido closed this as completed Jun 30, 2020
@majido majido added this to the scroll-animations-1 FPWD milestone Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majido majido

Labels
scroll-animations-1 Current Work
Projects
None yet
Milestone
scroll-animations-1 FPWD
Development

No branches or pull requests
2 participants
@andruud @majido