Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-color-adjust] It's a bit unfortunate that user stylesheets can't specify arbitrary colors. #5779

Closed
emilio opened this issue Dec 10, 2020 · 2 comments
Labels
Closed as Retracted When the person who raised the issue thinks that there's no issue after all. Closed Rejected as Wontfix by CSSWG Resolution Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-color-adjust-1 Current Work

Comments

@emilio
Copy link
Collaborator

emilio commented Dec 10, 2020

I don't think this is enough of an issue to revert the resolution of #4915, but I don't think it was discussed there so I wanted to raise it just in case there's any case we hadn't thought about.

One of the nice things of the revert-based forced-colors is that user and user-agent stylesheets worked as-is. We fixed UA stylesheets to use system colors where they weren't doing so, so that's covered, but user stylesheets won't be able to specify arbitrary colors anymore.

I think most of the use cases that I could think of for having arbitrary colors in a user sheet if you're using forced-colors are either minor, covered by system colors, or spec issues (#5778).

But there are probably other use cases which I might have missed (I know lots of extensions inject user stylesheets, for example...), so I think it'd be worth a look from other WG/community members just in case.

@tabatkins
Copy link
Member

If they're targetting a specific thing, user stylesheets can use forced-color-adjust: none and then use whatever colors they want; if they're spamming colors generally across the page so that that's not appropriate, uh, wouldn't they just change their forced colors to match that preference, then?

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed [css-color-adjust] It's a bit unfortunate that user stylesheets can't specify arbitrary colors., and agreed to the following:

  • RESOLVED: Close no change
The full IRC log of that discussion <dael> Topic: [css-color-adjust] It's a bit unfortunate that user stylesheets can't specify arbitrary colors.
<dael> github: https://github.com//issues/5779
<dael> emilio: I don't htink it's huge. Came up when reviewing changes to forced colors. It's a bit unfortunate user colors stop working
<dael> emilio: I don't have a super great use case for user stylesheets spec arbitrary colors. I don't think it's huge but wanted to raise b/c it's weird.
<Rossen_> q?
<dael> fremy: I think we did consider it. You can spec any color and say forced color adjust none
<dael> emilio: Yeah
<dael> fremy: You want to do it anyway to disable backplate. You can say antying in stylesheet.
<fantasai> or stick to the forced colors palette
<dael> emilio: Would need to disable for everything but yeah. It's a different behavior. not a huge issue. Can disable forced-colors all together or change system colors to match what you want
<dael> Rossen_: Doesn't sound like there's anything ot resolve
<dael> emilio: Resolve no change
<dael> Rossen_: Objections:
<dael> RESOLVED: Close no change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed as Retracted When the person who raised the issue thinks that there's no issue after all. Closed Rejected as Wontfix by CSSWG Resolution Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-color-adjust-1 Current Work
Projects
None yet
Development

No branches or pull requests

4 participants