Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-fonts-5] Description of size-adjust descriptor is misleading #6133

Closed
jfkthame opened this issue Mar 24, 2021 · 1 comment
Closed

[css-fonts-5] Description of size-adjust descriptor is misleading #6133

jfkthame opened this issue Mar 24, 2021 · 1 comment
Labels
Closed Accepted by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-fonts-5

Comments

@jfkthame
Copy link
Contributor

Regarding size-adjust, the current draft says:

For size-adjust, when the descriptor value is a percentage, all metrics values of this font, including glyph advance sizes, are resolved as the given percentage multiplied by the used font size.

This is not correct, I think. It says that every metric -- so that'd be ascent, descent, x-height, cap-height, etc -- as well as every glyph advance will end up with the same value: the used font size multiplied by the size-adjust percentage.

I think it should say something more like:

All metrics values of this font, including glyph advances, are scaled by the given percentage, as are the rendered glyph images. However, the computed font size (and hence units such as em that depend on it) are unaffected.
@jfkthame jfkthame mentioned this issue Mar 25, 2021
Closed
fantasai added a commit to fantasai/csswg-drafts that referenced this issue Mar 27, 2021
@fantasai
[css-fonts-5] Split out size-adjust from metric overrides section w3c…
c876032 
…#6112 and improve its description w3c#6133.
fantasai added a commit to fantasai/csswg-drafts that referenced this issue Apr 6, 2021
@fantasai
[css-fonts-5] Split out size-adjust from metric overrides section w3c…
df02447 
…#6112 and improve its description w3c#6133.
@fantasai
Copy link
Collaborator

fantasai commented Jun 9, 2021

@jfkthame I think this was fixed in df02447#diff-3e391c0014318f36debe3e04cffbfc458ebcae3176bda0b904641e758106bbd1

@fantasai fantasai added Closed Accepted by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. labels Jun 9, 2021
@fantasai fantasai closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-fonts-5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tabatkins @fantasai @jfkthame