Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flexbox][css-align][css-grid] Incompatible spec for align-self computed value when 'auto' #644

Closed
javifernandez opened this issue Oct 25, 2016 · 3 comments

Comments

@javifernandez
Copy link
Contributor

@javifernandez javifernandez commented Oct 25, 2016

It seems that last month it was agreed than 'auto' values on align-self and justify-self compute to itself from now on, based on #440 .

I have to say that it's surprising that, after some many discussions, we've ended up with this approach. But anyway, this is in conflict with what the current draft of Flexible Box states for the align-self property:

On absolutely positioned elements, a value of auto computes to itself. On all other elements, a value of auto for align-self computes to the value of align-items on the element’s parent, or stretch if the element has no parent.

I think we need to match both specs, otherwise the implementation of the CSS Alignment specification is going to be really difficult.

@fantasai
Copy link
Collaborator

@fantasai fantasai commented Nov 25, 2016

I think the key limitations leading to this were that a) absolutely-positioned boxes need auto to compute to itself whereas all other boxes take the value from the parent's align-items, making the computation depend on position, and b) Gecko folks don't like cross-property computed value dependencies. Since neither animation nor inheritance provide significant use cases here that we need to consider, we went with the route that yields less accurate computed values in favor of ease-of-implementation.

@mrego
Copy link
Member

@mrego mrego commented Feb 22, 2017

Hi @fantasai it seems that as part of this change, you forget to update the text on the spec:

On absolutely positioned elements, a value of auto computes to itself. On all other elements, a value of auto for align-self computes to the value of align-items on the element’s parent, or stretch if the element has no parent.

fantasai added a commit that referenced this issue Feb 23, 2017
…ution to compute 'auto' to 'auto' always)
@fantasai
Copy link
Collaborator

@fantasai fantasai commented Feb 23, 2017

Thanks, @mrego :) Should be fixed now.

triple-underscore added a commit to triple-underscore/triple-underscore.github.io that referenced this issue Feb 25, 2017
Restore definition of auto which was lost in previous commit. >_<;;
w3c/csswg-drafts@fb5f90f
123a433330a

Remove paragraph wrt computed values per
w3c/csswg-drafts#644
(WG resolution to compute 'auto' to 'auto' always)
w3c/csswg-drafts@bccee2e
f083b1b5d20
@fantasai fantasai added this to the Published css-flexbox-1 2017-10-19 milestone Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants